Skip to content

Transform definitions and related codegen fixes #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
teh-cmc merged 26 commits into from
Jul 11, 2023
Merged

Transform definitions and related codegen fixes #2654

teh-cmc merged 26 commits into from
Jul 11, 2023

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 10, 2023 •
edited by github-actions bot
Loading

  • Introduce IDL definitions for the Transform3D family of types
  • Fixes the top-level nullable union field in struct mess + add related fuzzing test cases
  • Fixes an issue with arrays of booleans + add related fuzzing test case
  • Fixes an issue with lists and fixed-size lists of transparent objects + add related fuzzing test case
  • Other fixes and improvements, see commits

Required for #2639

Checklist

@teh-cmc teh-cmc added 🪳 bug Something isn't working codegen/idl labels Jul 10, 2023
@teh-cmc teh-cmc force-pushed the cmc/rust_codegend_transforms branch from 67baa30 to a053606 Compare July 10, 2023 16:22
@teh-cmc teh-cmc marked this pull request as ready for review July 10, 2023 17:48
@teh-cmc teh-cmc requested a review from abey79 July 10, 2023 17:48
@abey79
Copy link
Member

abey79 commented Jul 10, 2023 •
edited
Loading

The CI failure is due to the circular import induced by type aliases:

Scale3DLike = Union[Scale3D, datatypes.Vec3DLike]  # <---

Scale3DArrayLike = Union[
    Scale3D,
    Sequence[Scale3DLike],
]

I suggest we ignore that for the purpose of this PR, as this is addressed by #2639 where I conditionally define type aliases behind a TYPE_CHECKING guard. This would temporarily break the CI on main, though.

Edit: nvm, I pushed a quick fix for that error (complete with wrong handling of indentation since I can't get it right—will be fixed in the next PR anyways).

abey79
abey79 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@teh-cmc teh-cmc merged commit 5311903 into main Jul 11, 2023
@teh-cmc teh-cmc deleted the cmc/rust_codegend_transforms branch July 11, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abey79 abey79 abey79 approved these changes

Assignees

No one assigned

Labels

🪳 bug Something isn't working codegen/idl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@teh-cmc @abey79