Fix order attribute not being mandatory in some situations
#2618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
force-pushed
the
cmc/order_mandatory
branch
2 times, most recently
from
639b717 to
8ef3849
Compare
3 tasks
emilk
approved these changes
Jul 7, 2023
Member
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Why is it always mandatory, even when there is only one field in a struct? It adds so much noise :/
Member
Author
I'm all for adding user-friendly exceptions such as this yep. |
teh-cmc
force-pushed
the
cmc/order_mandatory
branch
from
8ef3849 to
525a3e7
Compare
Member
Author
teh-cmc
added a commit
that referenced
this pull request
Jul 7, 2023
…2626) **COMMIT BY COMMIT!** What the title says. Adding support for sparse unions would be trivial, but nobody ever uses those so I've refrained from doing it for now. Fixes #2625 Requires #2618 Requires #2619 --- ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2626) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2626) - [Docs preview](https://rerun.io/preview/pr%3Acmc%2Farrow_union/docs) - [Examples preview](https://rerun.io/preview/pr%3Acmc%2Farrow_union/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2527
Checklist