Remove defunct entity filter from Text Space View #2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
approved these changes
Jun 28, 2023
Member
jleibs
left a comment
jleibs
left a comment
There was a problem hiding this comment.
Is the argument here that is this is no different from toggling visibility on the entities directly?
Member
Author
|
yep, saw no reason to fix it since it is a redundant mechanism. I believe it is from a time when we didn't have visibility toggles or at least when we didn't have them available via a unified mechanism |
emilk
pushed a commit
that referenced
this pull request
Jun 29, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What Noticed while testing: Removed text entity filter ui; this was already defunct on main and is redundant to entity visibility property. Was originally part of #2522 Test via `python ./examples/python/text_logging/main.py` ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2544 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/8e1e06b/docs Examples preview: https://rerun.io/preview/8e1e06b/examples <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Noticed while testing: Removed text entity filter ui; this was already defunct on main and is redundant to entity visibility property.
Was originally part of #2522
Test via
python ./examples/python/text_logging/main.pyChecklist
PR Build Summary: https://build.rerun.io/pr/2544
Docs preview: https://rerun.io/preview/8e1e06b/docs
Examples preview: https://rerun.io/preview/8e1e06b/examples