Codegen'd Rust/Arrow: wip buffer #2520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2023
teh-cmc
force-pushed
the
cmc/hope_rust_serde_3/semantic_fixes
branch
from
49ae282 to
6687f15
Compare
teh-cmc
force-pushed
the
cmc/hope_rust_serde_4/serialization
branch
21 times, most recently
from
d8065fa to
3fa6b0d
Compare
teh-cmc
force-pushed
the
cmc/hope_rust_serde_3/semantic_fixes
branch
from
8261732 to
84c5bfe
Compare
teh-cmc
force-pushed
the
cmc/hope_rust_serde_4/serialization
branch
2 times, most recently
from
177ab42 to
1b92d57
Compare
teh-cmc
force-pushed
the
cmc/hope_rust_serde_4/serialization
branch
3 times, most recently
from
4c68bbd to
730ef29
Compare
teh-cmc
changed the title
teh-cmc
force-pushed
the
cmc/hope_rust_serde_4/serialization
branch
from
730ef29 to
c727698
Compare
teh-cmc
force-pushed
the
cmc/hope_rust_serde_4/serialization
branch
from
c727698 to
0421e0d
Compare
emilk
pushed a commit
that referenced
this pull request
Jun 29, 2023
…2484) **Best reviewed on a commit-by-commit basis; in particular the `rerun codegen` commit is nothing but generated code.** This PR upgrades the Rust code generator to make use of actual `TokenStream`s (i.e. `syn` & `quote`) rather than manipulating raw strings; because what's coming in the following PRs puts us way past the complexity threshold for using simple strings. Interestingly, while `syn` & `quote` were obviously designed with Rust in mind, they aren't specific to Rust so much as they are made to work with bracket-base languages. I.e. the Rust code generator becomes a nice starting point for a C or C++ one. --- - #2484 - #2485 - #2487 - #2520 --- <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2484 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/cf52fbc/docs Examples preview: https://rerun.io/preview/cf52fbc/examples <!-- pr-link-docs:end -->
emilk
pushed a commit
that referenced
this pull request
Jun 29, 2023
**Best reviewed on a commit-by-commit basis; in particular the `rerun
codegen` commit is nothing but generated code.**
This PR updates (or rather, downdates?) the IDL definitions of
`Points2D` and its components to make sure they match the legacy ones
(e.g. `Point2D` is back to being a `struct { x, y }` rather than a
`[f32; 2]`).
We'll revert that once we're done with the backporting/migration and get
rid of the legacy stuff.
UPDATE: This now also includes the `attr.rerun.legacy_fqname` attribute,
which does what you think it does.
---
- #2484
- #2485
- #2487
- #2520
---
<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2485
<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/41e265f/docs
Examples preview: https://rerun.io/preview/41e265f/examples
<!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore this, it's a trap
PR Build Summary: https://build.rerun.io/pr/2520
Docs preview: https://rerun.io/preview/0421e0d/docs
Examples preview: https://rerun.io/preview/0421e0d/examples