Skip to content

Update wasm-bindgen to 0.2.86 #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jleibs merged 8 commits into from
May 19, 2023
Merged

Update wasm-bindgen to 0.2.86 #2161

jleibs merged 8 commits into from
May 19, 2023

Conversation

@emilk
Copy link
Member

@emilk emilk commented May 17, 2023 •
edited by github-actions bot
Loading

What

Update wasm-bindgen to 0.2.86

This release contains the fix for 2GiB memory usage, meaning we no longer need to use a forked version of wasm-bindgen-cli

Does not fix #2152

Tested in Firefo, Chromium, and Safari

Checklist

PR Build Summary: https://build.rerun.io/pr/2161

@emilk emilk added 🕸️ web regarding running the viewer in a browser dependencies concerning crates, pip packages etc labels May 17, 2023
emilk
emilk commented May 17, 2023
View reviewed changes
crates/re_log/Cargo.toml
# web dependencies:
[target.'cfg(target_arch = "wasm32")'.dependencies]
js-sys = "0.3"
wasm-bindgen = "=0.2.84"
Copy link
Member Author

@emilk emilk May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "=… here and below was a mistake. We have a Cargo.lock file for that. We don't want force any potential users of our crates to use a specific wasm-bindgen version. However, we do want to force them to use at least 0.2.86 since it contains the critical fix for 2GiB RAM usage

@emilk emilk mentioned this pull request May 17, 2023
Closed
14 tasks
@emilk
Copy link
Member Author

emilk commented May 17, 2023 •
edited
Loading

Oh right, this needs a new CI docker image too…

EDIT: ci_docker/publish.sh fails on mac with

 => ERROR [ 6/11] RUN cargo install cargo-deny &&     cargo install cargo-cranky &&     cargo install cargo-  49.1s 
------                                                                                                              
 > [ 6/11] RUN cargo install cargo-deny &&     cargo install cargo-cranky &&     cargo install cargo-benchcmp:      
#0 0.677     Updating crates.io index                                                                               
#0 49.04 Killed                                                                                                     
------                                                                                                              
ERROR: failed to solve: executor failed running [/bin/sh -c cargo install cargo-deny &&     cargo install cargo-cranky &&     cargo install cargo-benchcmp]: exit code: 137

@emilk emilk mentioned this pull request May 19, 2023
Merged
1 task
@jleibs jleibs merged commit c6aa325 into main May 19, 2023
@jleibs jleibs deleted the emilk/update-wasm-bindgen branch May 19, 2023 13:39
emilk added a commit that referenced this pull request May 22, 2023
@emilk @jleibs
Update wasm-bindgen to 0.2.86 (#2161)
e87d954 
* Update wasm-bindgen to 0.2.86
* Prepare for new docker image
* Switch the Dockerfile to use setup_web.sh

---------

Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jleibs jleibs jleibs approved these changes

Assignees

No one assigned

Labels

dependencies concerning crates, pip packages etc 🕸️ web regarding running the viewer in a browser

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wasm-bindgen error

3 participants

@emilk @jleibs