Skip to content

Migrate arrow schemas right after decoding them from protobuff#11032

Merged
emilk merged 6 commits intomainfrom
emilk/migrate-schemas-in-proto
Sep 4, 2025
Merged

Migrate arrow schemas right after decoding them from protobuff#11032
emilk merged 6 commits intomainfrom
emilk/migrate-schemas-in-proto

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Aug 28, 2025 •
edited
Loading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 1888fdf https://rerun.io/viewer/pr/11032 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 🔩 data model Sorbet dataplatform Rerun Data Platform integration labels Aug 28, 2025
emilk
emilk commented Aug 28, 2025
View reviewed changes
@emilk emilk marked this pull request as ready for review August 28, 2025 16:40
@emilk emilk mentioned this pull request Aug 28, 2025
Merged
teh-cmc
teh-cmc approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of all the other complexities we talked about and still have to address, I think that specific bit always makes sense anyhow.

andrea-reale pushed a commit that referenced this pull request Aug 29, 2025
@emilk
Revert BinaryArray migration (#11039)
b89c144 
### Related
* Reverts #10875
* Reverts #11005
* Fixes #11028
* Closes #11032
* Re-opens #10929
* Re-opens #10973

### What
Reverts the the change from `List<u8>` to `Binary` because of Rerun
Cloud migration woes.

Hopefully temporarily.
andrea-reale pushed a commit that referenced this pull request Sep 2, 2025
@emilk @andrea-reale
Revert BinaryArray migration (#11039)
6fc724c 
### Related
* Reverts #10875
* Reverts #11005
* Fixes #11028
* Closes #11032
* Re-opens #10929
* Re-opens #10973

### What
Reverts the the change from `List<u8>` to `Binary` because of Rerun
Cloud migration woes.

Hopefully temporarily.
@andrea-reale andrea-reale mentioned this pull request Sep 2, 2025
Merged
@teh-cmc
Copy link
Copy Markdown
Contributor

teh-cmc commented Sep 2, 2025

This makes sense regardless of the big revert I believe

@emilk emilk reopened this Sep 2, 2025
@emilk emilk added the do-not-merge Do not merge this PR label Sep 2, 2025
@emilk emilk marked this pull request as draft September 2, 2025 10:08
@emilk emilk force-pushed the emilk/migrate-schemas-in-proto branch from 4809a76 to c11aa40 Compare September 4, 2025 11:07
@emilk emilk removed the do-not-merge Do not merge this PR label Sep 4, 2025
@emilk emilk marked this pull request as ready for review September 4, 2025 11:11
@emilk emilk merged commit 24fb85f into main Sep 4, 2025
40 checks passed
@emilk emilk deleted the emilk/migrate-schemas-in-proto branch September 4, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teh-cmc teh-cmc teh-cmc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🪳 bug Something isn't working 🔩 data model Sorbet dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilk @teh-cmc