Fix MCAP parsers to handle Blob as LargeBinary#11005
Merged
Conversation
oxkitsune
added
🪳 bug
Contributor
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
approved these changes
Aug 26, 2025
andrea-reale
pushed a commit
that referenced
this pull request
Aug 29, 2025
andrea-reale
pushed a commit
that referenced
this pull request
Sep 2, 2025
andrea-reale
added a commit
that referenced
this pull request
Sep 2, 2025
(cherry picking from #11039) ### Related * Reverts #10875 * Reverts #11005 * Fixes #11028 * Closes #11032 * Re-opens #10929 * Re-opens #10973 ### What Reverts the the change from `List<u8>` to `Binary` because of Rerun Cloud migration woes. Hopefully temporarily. Co-authored-by: Emil Ernerfeldt <[email protected]>
aedm
added
exclude from changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Blobas arrowBinary#10875What
#10875 changed the underlying arrow datatype for
BlobtoLargeBinary. This broke the MCAP parsers which manually created arrays containingBlobdata.