Skip to content

Enable backwards compatibility checks for Python-only snippets#10898

Merged
emilk merged 7 commits intomainfrom
emilk/improve-snippet-backwards-compatibility-check
Aug 15, 2025
Merged

Enable backwards compatibility checks for Python-only snippets#10898
emilk merged 7 commits intomainfrom
emilk/improve-snippet-backwards-compatibility-check

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Aug 14, 2025

We have a lot of Python-only code snippets. Unfortunately these weren't covered by backwards compatibility checks… until now!

TODO

  • @rerun-bot full-check

@emilk emilk added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 14, 2025
@grtlr grtlr self-requested a review August 14, 2025 12:17
@grtlr
Copy link
Copy Markdown
Member

grtlr commented Aug 14, 2025

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16964927823

Copy link
Copy Markdown
Member

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! lgtm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
0e12d36 https://rerun.io/viewer/pr/10898 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk force-pushed the emilk/improve-snippet-backwards-compatibility-check branch from 07ce737 to 9eda102 Compare August 14, 2025 13:39
@emilk
Copy link
Copy Markdown
Member Author

emilk commented Aug 14, 2025

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2025

Latest documentation preview deployed successfully.

Result Commit Link
0e12d36 https://landing-afvjovl0h-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@github-actions
Copy link
Copy Markdown
Contributor

@emilk emilk force-pushed the emilk/improve-snippet-backwards-compatibility-check branch from 9eda102 to c6146e6 Compare August 14, 2025 14:04
@emilk emilk force-pushed the emilk/improve-snippet-backwards-compatibility-check branch from c6146e6 to e7c7eb5 Compare August 14, 2025 20:48
@emilk
Copy link
Copy Markdown
Member Author

emilk commented Aug 14, 2025

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

@emilk
Copy link
Copy Markdown
Member Author

emilk commented Aug 15, 2025

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

@emilk emilk merged commit 6849a46 into main Aug 15, 2025
87 of 89 checks passed
@emilk emilk deleted the emilk/improve-snippet-backwards-compatibility-check branch August 15, 2025 07:25
emilk added a commit that referenced this pull request Aug 24, 2025
This changes the encoding of the component column containing bobs from
`List<List<u8>>` to `List<Binary>`, i.e. `BinaryArray` or
`LargeBinaryArray` (both are supported!).

Old data is migrated on load.

This adds support for blobs larger than 2 GiB, e.g. large video files.

In the viewer we now support both 32-bit and 64-bit offsets for the
binary data (`BinaryArray vs LargeBinaryArray`).
This is _technically_ a type of datatype generics. Sort of. See
#9144

* The SDK code (Rust, Python, C++) always encoded as 64-bit (supporting
>2GiB videos).
* Legacy blobs are converted from 32-bit List<u8> to 64-bit binary

## TODO
* [x] Fix python
* [x] Merge #10899
* [x] Merge #10898
* [x] Use 63-bit `LargeBinary` instead of 31-bit `Binary`
  * Closes #10929
  * Closes #10973
* [x] `@rerun-bot full-check`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants