[REVERTED] Support 2GiB+ videos: Encode Blob as arrow Binary#10875
Merged
[REVERTED] Support 2GiB+ videos: Encode Blob as arrow Binary#10875
Blob as arrow Binary#10875Conversation
Contributor
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Contributor
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
3e42878 to
5aec85b
Compare
emilk
commented
Aug 12, 2025
| "attr.rust.tuple_struct" | ||
| ) { | ||
| data: [ubyte] (order: 100); | ||
| data: [ubyte] (order: 100, "attr.rerun.override_type": "binary"); |
d18ad87 to
6a2b085
Compare
6a2b085 to
ec623a3
Compare
Member
Author
|
@rerun-bot full-check |
Contributor
emilk
commented
Aug 13, 2025
Member
Author
There was a problem hiding this comment.
The new arrow UI never shows the contents of blob, just their size
629b15b to
14bbb97
Compare
Member
Author
|
@rerun-bot full-check |
Contributor
Member
Author
|
This is a big PR. I'll split it in two. |
14bbb97 to
875ca13
Compare
emilk
added a commit
that referenced
this pull request
Aug 14, 2025
### Related * Split out from #10875 See commit messages
875ca13 to
1f47c5e
Compare
Member
Author
|
@rerun-bot full-check |
Contributor
Member
Author
|
@rerun-bot full-check |
Contributor
This was referenced Aug 28, 2025
andrea-reale
pushed a commit
that referenced
this pull request
Aug 29, 2025
andrea-reale
pushed a commit
that referenced
this pull request
Sep 2, 2025
andrea-reale
added a commit
that referenced
this pull request
Sep 2, 2025
(cherry picking from #11039) ### Related * Reverts #10875 * Reverts #11005 * Fixes #11028 * Closes #11032 * Re-opens #10929 * Re-opens #10973 ### What Reverts the the change from `List<u8>` to `Binary` because of Rerun Cloud migration woes. Hopefully temporarily. Co-authored-by: Emil Ernerfeldt <[email protected]>
Blob as arrow BinaryBlob as arrow Binary
1 task
emilk
added a commit
that referenced
this pull request
Sep 4, 2025
### Related * https://linear.app/rerun/project/cloud-support-for-evolution-of-data-schemas-59fb0b1a81ee/overview * Solves #11028 * rerun-io/dataplatform#1605 * Follows #10875 ### What This migrates all arrow schemas to the latest sorbet version right after decoding them off the gRPC wire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the encoding of the component column containing bobs from
List<List<u8>>toList<Binary>, i.e.BinaryArrayorLargeBinaryArray(both are supported!).Old data is migrated on load.
This adds support for blobs larger than 2 GiB, e.g. large video files.
In the viewer we now support both 32-bit and 64-bit offsets for the binary data (
BinaryArray vs LargeBinaryArray).This is technically a type of datatype generics. Sort of. See #9144
TODO
LargeBinaryinstead of 31-bitBinary@rerun-bot full-check