Repository navigation
Commit 1e9f9f1
authored
Remove workarounds for upstream fixes that have landed
### Related
* Part of RR-5804
`re_dataframe_ui/src/header_tooltip.rs`: arrow 58.3 implements `Display`
for
`DataType` (apache/arrow-rs#8351), so the copy button no longer needs
pretty-`Debug`. The button label one line above already used `Display`,
so the
label and the clipboard now agree.
`re_dataframe_ui/src/filters/boolean.rs`: `array_sort` keeps inner list
nullability again (apache/datafusion#19947, reachable from 53.0.0; we
resolve
54.1.0), so the `arrow_cast` to `List(Boolean)` is redundant.
`test_boolean_equals_list_nullable` covers the `nullable: false` shape
that used
to fail, and its snapshots are unchanged.
`re_audio/src/waveform_envelope.rs`: `Rangef::union` exists upstream
(emilk/egui#8603) and our `[patch]` resolves egui from `main`.
`re_viewer/src/app/{logic,mod}.rs`: egui 0.36 syncs the OS window theme
itself
in `end_pass` (emilk/egui#8299), gated on `Options::sync_window_theme`,
which
defaults to true and is never disabled here. `sync_native_window_theme`
and the
`last_window_theme` cache are dead.
### What
Four TODOs pointed at upstream issues that are now closed, and each fix
is
already in the version we resolve.
### Agent
🤖 This PR was prepared by a coding agent.
Source-Ref: 385c5b729ef8b906610d160ed2b753a0e8e145e41 parent 703fb00 commit 1e9f9f1
5 files changed
Lines changed: 7 additions & 39 deletions
File tree
- crates
- top/re_viewer/src/app
- utils/re_audio/src
- viewer_support/re_dataframe_ui/src
- filters
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
91 | 90 | | |
92 | 91 | | |
93 | 92 | | |
94 | 93 | | |
95 | 94 | | |
96 | 95 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | 96 | | |
116 | 97 | | |
117 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | 176 | | |
180 | 177 | | |
181 | 178 | | |
| |||
571 | 568 | | |
572 | 569 | | |
573 | 570 | | |
574 | | - | |
575 | 571 | | |
576 | 572 | | |
577 | 573 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
71 | 74 | | |
72 | 75 | | |
73 | 76 | | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | 77 | | |
81 | 78 | | |
82 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
199 | 198 | | |
200 | 199 | | |
201 | 200 | | |
202 | | - | |
203 | 201 | | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
| 202 | + | |
209 | 203 | | |
210 | 204 | | |
211 | 205 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
| 169 | + | |
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
| |||
0 commit comments