-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Error types to work in browsers without v8 engine #40
Conversation
Awesome, thank you! I wonder, if we should move |
I tested this order in Firefox and IE (latest). So I would leave it as it is. |
I just looked into |
BTW, the test failed due to a timeout. Your PR was working fine. |
Improved Error types to work in browsers without v8 engine
One specific question: In Firefox and IE do the errors have a |
Firefox does have a non-standard stack property. See https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Error/stack And IE also has a stack property. See So it would be possible to write the stack trace to the console. Regarding the |
Alright, I keep the Thanks for your feedback! |
I just published v0.4.1 on NPM. |
Error.captureStackTrace is only supported in browsers with v8 engine.
With this pull request I can use request-promise in all browsers.