Repository navigation
Description
Before I go into the details and reasoning I’ll get straight to the point. The most valuable thing request can do for the JavaScript ecosystem is to go into maintenance mode and stop considering new features or major releases.
Apologies in advance to the other committers on request that have been doing their best to improve it, but it’s for the best.
2009
The first version of request was one of the first modules ever created for the Node.js ecosystem. The earliest versions were written to APIs that pre-date the standard callback interface, streams, node_modules and npm. For the first few years, request and Node.js evolved together, each learning from the other. As Node.js improved and migrated core interfaces so did request. As request adopted changes to the core http library and streams it also informed improvements like the pipe event (which enabled request’s one line proxy) and one of Core http’s many re-writes (the one I had to write).
npm
request was one of the first modules added to the npm registry. As npm grew so did dependence on request. Even now, when npm is used far more for front-end than back-end work, request remains one of the most depended on modules in the registry. As I write this, 41K modules depend on request and it is downloaded 14 million times a week.
The place request has in the Node.js ecosystem is no longer one of an innovator but of an incumbent. If you Google for how to do something with HTTP in Node.js the examples are likely to show request as the client and express as the server. This has two notably bad effects.
It’s much harder for new libraries accomplishing similar tasks to gain adoption because of the incumbent position request holds over the ecosystem. It’s also very hard to change request in any meaningful way as the change not only may not be adopted by the majority of its dependents but it would put it out of alignment with the thousands of blog posts and stack overflow responses that use request.
Modern JavaScript
The last few years have been dramatic ones in JavaScript. Features people had talked about for years went from ideas, to standards, to features you can reliably depend on in most environments. The speed at which these have been adopted is staggering, mostly thanks to auto-updating browsers and an aggressive Node.js release schedule.
The patterns at the core of request are out of date. A few people might argue with that assessment, and I know who they are so I won’t be surprised, but it’s true. I have often been skeptical of the impact some of these features would have only to find myself adopting them wholesale not long after they are available in only the latest release of Node.js.
There’s a transition happening now in the ecosystem to these patterns. How messy that will be is still up in the air and I’m not going to try and read the tea leafs and figure out what the future looks like in that regard. The question for request is “Do we try to survive through that transition?” A year ago, I thought the answer was obvious and that we would, but now I’m convinced of the opposite.
A version of request written to truly embrace these new language patterns is, effectively, a new module. I’ve explored this space a bit already and have a project I’m quite happy with but it is incompatible with request in every conceivable way. What’s the value in a version of request that is incompatible with the old patterns yet not fully embracing the new ones? What’s the point in being partially compatible when there’s a whole world of new modules, written by new developers, that are re-thinking these problems with these patterns in mind?
The best thing for these new modules is for request to slowly fade away, eventually becoming just another memory of that legacy stack. Taking the position request has now and leveraging it for a bigger share of the next generation of developers would be a disservice to those developers as it would drive them away from better modules that don’t have the burden of request’s history.
Maintenance Mode
Here’s the plan.
requestwill stop accepting new features.requestwill stop considering breaking changes.- The committers that are still active will try to merge fixes in a timely fashion, no promises though.
- Releases will be fully automated, any merge into master will be published. I’ve already built this for some other projects using GitHub Actions.
- We’re going to have to remove inactive collaborators and enforce 2fa, because commit rights will effectively become npm publish rights.
Activity
reconbot commentedon Mar 30, 2019
I fully support this, I think a warning message and/or deprecating new releases is in order.
As for the change in process and guidelines, it makes my job a lot easier 👌
simov commentedon Mar 31, 2019
Very well said @mikeal. I'm pinning this issue to gain more visibility.
reconbot commentedon Mar 31, 2019
Things we might do - please discuss and volunteer!
requestalternatives Alternative libraries to request #31433.x) so project’s in active maintenance get a warning but older projects continue as usualanalog-nico commentedon Apr 1, 2019
It makes a lot of sense! I will slowly adopt this policy for the
request-promisefamily as well. Cheers to your important contributions to the node ecosystem!bajtos commentedon Apr 2, 2019
Please be careful about deprecation. As Mikael wrote above, there are 41K modules depending on
request. Many of these modules are useful in the current state and work well for their users, but their maintainers may not have time to rework those modules to use something else thanrequest. By deprecatingrequestat install time, you will basically deprecate a large portion of npm module ecosystem.As I see it, maintenance mode is not the same thing as deprecation.
reconbot commentedon Apr 2, 2019
I hear you. The full text
I think we should eventually deprecate
requestbecause I don't want new projects to use it.I've been trying to triage the issues and prs down to a list we can solve, but there are bugs that we cannot fix without a breaking change. Therefore they wont get fixed and new users will have issues.
For example following redirects looses request bodies and cookies, and url parsing to remove relative paths are both bugs but I'm not sure they'll ever be fixed.
Maybe deprecation isn't the right answer, but I don't know how else to approach that.
Does that make sense?
mikeal commentedon Apr 2, 2019
Let’s just bump the major version when we deprecate. That way most people depending on the project won’t see this error until they try to upgrade to a new major, which means they are actively developing it and really should look for an alternative.
nylen commentedon Apr 3, 2019
I'm proud to have been part of the history of
request. I will also check outbent, it looks interesting, and small, which is more important to me these days.Fine to remove me.
JonathanRowell commentedon Apr 4, 2019
As a programmer who is VERY grateful for the module and who uses it all the time I WANT to use it on new projects.
rimiti commentedon Apr 4, 2019
I'm proud having used this amazing tool. It forced the community to improve. 🙏
If you need help to maintain it do not hesitate to contact me.
pdxmholmes commentedon Apr 4, 2019
While I respect your decision, I would ask you to consider how much real world, production, code relies on request currently. It's far more than even NPM stats can tell you. I fully understand wanting to move on to a new thing and doing something in a new, more interesting way...this is the JavaScript ecosystem after all, have to chase the new thing. But please consider the amount of time and money you'd be costing professional engineering organizations by wholesale deprecating request. If you want to leave it in maintenance mode, that's fine, but understand that plenty of people have absolutely no practical reason to change libraries. Forcing people to change because of ideology is going to lead to frustration.
Regardless, thanks for the hard work everyone has put in to this library.
kibertoad commentedon Apr 5, 2019
I wonder what library could be considered modern and recommended now. Superagent is mostly in maintenance mode right now, axios not too active altogether.
481 remaining items
riclf commentedon Oct 11, 2022
Vilx2 commentedon Oct 11, 2022
jslegers commentedon Oct 11, 2022
tushart681 commentedon Oct 19, 2022
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (debug-js/debug#797)
npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: request has been deprecated, see #3142
npm ERR! Cannot read properties of null (reading 'pickAlgorithm')
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\User.DESKTOP-GDKI8TK\AppData\Local\npm-cache_logs\2022-10-19T15_42_31_034Z-debug-0.log
tushart681 commentedon Oct 19, 2022
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (debug-js/debug#797)
npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: request has been deprecated, see #3142
npm ERR! Cannot read properties of null (reading 'pickAlgorithm')
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\User.DESKTOP-GDKI8TK\AppData\Local\npm-cache_logs\2022-10-19T15_42_31_034Z-debug-0.log
what can i do? when i install firebase tools , than i found this error
ggirishk commentedon Jan 28, 2023
Error: This command is not available when running the Angular CLI outside a w
orkspace.
rzr commentedon Feb 16, 2023
Hi, Is any user willing to co-maintain in @abandonware org ? let me know
https://purl.org/rzr/abandonware
Richienb commentedon Feb 16, 2023
The problem with request appears to not be a lack of community engagement, but rather the realisation that request is too mature for any significant changes to be made.
Not a problem with abandonment.
rzr commentedon Jul 27, 2023
Is there any fork that is planing to maintain it ?
birkskyum commentedon Sep 13, 2023
Would it make sense to make request a thin wrapper around a modern and safe solution in a patch or minor release?
That would allow all the 300k repos that depend on this to migrate automatically.
zzz6519003 commentedon Nov 11, 2024
先自我介绍
danieldanielecki commentedon Nov 12, 2024
Resources for your next certifications & learnings: https://github.com/Ditectrev
Comes with Web & PWA platform, and iOS/iPadOS/macOS app. #OpenSource
BREEZY22-23 commentedon Feb 4, 2025
Bot
jakeNiemiec commentedon Feb 5, 2025