Statistics-- update#8
Closed
renukamanavalan wants to merge 143 commits intosyslog_telemetry_sharedfrom
Closed
Conversation
zbud-msft
reviewed
Aug 16, 2022
Collaborator
zbud-msft
left a comment
zbud-msft
left a comment
There was a problem hiding this comment.
Why are we updating submodule, wpasupplicant?
| // Override this to define how to set up the environment. | ||
| void SetUp() override { | ||
| // by default , init should be false | ||
| cout<<"Default : isInit = "<<SonicDBConfig::isInit()<<endl; |
Collaborator
There was a problem hiding this comment.
Uses SWSS_LOG instead of cout
Owner
Author
There was a problem hiding this comment.
This is by design. For unit tests, we want the spew in stdout, so the build log will have it.
BTW, this is the same code from unit test of swsscommon.
| } | ||
| catch (exception &e) | ||
| { | ||
| printf("Unable to get DB Connector, e=(%s)\n", e.what()); |
Owner
Author
There was a problem hiding this comment.
Same as above --Not for unit tests.
Collaborator
|
I think you can also remove sonic-swss-common submodule update, as master sonic-buildimage has update |
Collaborator
|
You are updating submodule wpa-supplicant and there are conflicts with swss-common submodule as well |
Owner
Author
|
Incorrect submodule updates in this PR could not be reverted. Hence abandoning this PR. |
zbud-msft
pushed a commit
that referenced
this pull request
Aug 25, 2022
#### What I did [sonic-linkmgrd][master] submodule update 6c6151b Fix unstable unit tests (state change handler wasn't invoked) (#8) 2f7dc0a support code diff coverage (#5) 83f0002 Force mux state switch to standby if triggered from Cli (#6) signed-off-by: Jing Zhang [email protected]
zbud-msft
pushed a commit
that referenced
this pull request
Aug 25, 2022
* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <[email protected]> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <[email protected]> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <[email protected]> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <[email protected]> * Added BFN PSU cache (#9) Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] Fans and Fantray platform APIs update (#7) * [BFN] Updated SFP platform APIs (#10) Signed-off-by: Volodymyr Boyko <[email protected]> * [BFN] Updated platform API for thermal (#8) * Signed-off-by: Vadym Yashchenko <[email protected]> * Revert "[BFN] Fans and Fantray platform APIs update (#7)" (#11) This reverts commit c62a733. * Add support health monitor system (#15) Signed-off-by: Petro Bratash <[email protected]> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (#14) * Fix fix_alignment (#17) Signed-off-by: Petro Bratash <[email protected]> * [BFN] Improvement show environment (#16) * Added PSU temperature skip into platform.json (#18) Signed-off-by: Andriy Kokhan <[email protected]> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] fix fan status from Not OK to Ok (#19) * [BFN] Updated SFP platform plugin (#13) Signed-off-by: Volodymyr Boyko <[email protected]> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21) Signed-off-by: Mykola Gerasymenko <[email protected]> * [barefoot] Tmp fix vendor_rev (#22) Signed-off-by: Volodymyr Boyko <[email protected]> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <[email protected]> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <[email protected]> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <[email protected]> * [Newport] Thermal manager (#23) * Signed-off-by: Vadym Yashchenko <[email protected]> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <[email protected]> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (#30) Signed-off-by: Andriy Kokhan <[email protected]> Co-authored-by: KostiantynYarovyiBf <[email protected]> Co-authored-by: Vadym Yashchenko <[email protected]> Co-authored-by: Dmytro Lytvynenko <[email protected]> Co-authored-by: Volodymyr Boiko <[email protected]> Co-authored-by: Petro Bratash <[email protected]> Co-authored-by: Mykola Gerasymenko <[email protected]>
renukamanavalan
added a commit
that referenced
this pull request
Sep 4, 2022
* 3beaadc (HEAD, origin/master, origin/HEAD, master) Improve unit test for gnmi (#38) * a12fcd8 Merge pull request #13 from renukamanavalan/statistics * | 28b2f27 Enable unit test * | 65e3c8f Add log for authentication and add unit test. #12 * | 1b3b838 Merge pull request #8 from ganglyu/fix_pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)