Repository navigation
Commit d1d2885
feat(workflow-operator): read the generated module as UTF-8 in three test drivers (apache#8988)
### What changes were proposed in this PR?
The Python drivers in `MachineLearningScorerOpDescSpec`,
`FilledAreaPlotOpDescSpec` and `TreePlotOpDescSpec` opened the generated
module without an encoding, so Python decoded it with the locale's,
which is cp1252 on Windows. The spec writes it as UTF-8. Each driver now
passes `encoding="utf-8"`, as the drivers that read Plotly HTML already
do.
### Any related issues, documentation, discussions?
Closes apache#8976
### How was this PR tested?
The three specs pass locally (51 tests). The generated modules are ASCII
today, so the change only matters once one is not.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5.5 <[email protected]>1 parent 5a44b5b commit d1d2885
3 files changed
Lines changed: 3 additions & 3 deletions
File tree
- common/workflow-operator/src/test/scala/org/apache/texera/amber/operator
- machineLearning/Scorer
- visualization
- filledAreaPlot
- treeplot
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
397 | | - | |
| 397 | + | |
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
271 | 271 | | |
272 | 272 | | |
273 | 273 | | |
274 | | - | |
| 274 | + | |
275 | 275 | | |
276 | 276 | | |
277 | 277 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
| 139 | + | |
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| |||
0 commit comments