Repository navigation
Commit 4b526eb
authored
chore(amber): remove the unused EmptyReplayLogger (apache#7452)
### What changes were proposed in this PR?
Deletes `EmptyReplayLogger` and its spec — a no-op `ReplayLogger` that
nothing in the engine ever constructs. Pure deletion, no behaviour
change: **−171 lines**.
The live null object for log replay sits one layer up, at the manager.
`EmptyReplayLogManagerImpl` inherits the `ReplayLogManager` trait's
non-logging `withFaultTolerant`, so it never needs a logger at all:
```
ReplayLogManager.scala:51 -> EmptyReplayLogManagerImpl (no-op manager, live)
ReplayLogManager.scala:109 -> new ReplayLoggerImpl() (the only ReplayLogger built in main)
EmptyReplayLogger (never instantiated)
```
`69b7f9bc1` (apache#2230) added `ReplayLogger`, `ReplayLoggerImpl`,
`EmptyReplayLogger` and `ReplayLogManager` in a single commit, so
nothing ever moved layers — `EmptyReplayLogger` was unwired from the day
it landed. No configuration selects a logger class by name either, so
there is no path that revives it.
> Reviewer note: the abstract base `ReplayLogger` is **not** touched —
`ReplayLoggerImpl` extends it and is unaffected. It does end up with a
single subclass and no declared-type site once this lands, so collapsing
it is tracked separately in apache#7673; that one edits live code, while this
PR stays a pure dead-code deletion. `EmptyReplayLogger` acquired unit
tests during the 2026 coverage work (apache#5554), which is why it currently
looks live; the spec covers this class and nothing else.
### Any related issues, documentation, discussions?
Closes apache#7449
### How was this PR tested?
Existing tests only — this PR adds none, since it removes code and the
spec that covered it.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"` — success.
Verification, re-runnable by a reviewer:
```
git grep -n EmptyReplayLogger # only the two deleted files
git grep -n "extends ReplayLogger" -- amber/src/main # ReplayLoggerImpl remains
git log -S "new EmptyReplayLogger" --all # only the apache#5554 spec commits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)1 parent 3b19f76 commit 4b526eb
2 files changed
Lines changed: 0 additions & 171 deletions
File tree
- amber/src
- main/scala/org/apache/texera/amber/engine/architecture/logreplay
- test/scala/org/apache/texera/amber/engine/architecture/logreplay
0 commit comments