Repository navigation
Commit 154042a
authored
feat(pyamber): reject invalid port booleans (apache#8240)
### What changes were proposed in this PR?
The Python GlobalPortIdentity decoder now rejects invalid boolean tokens
instead of silently treating them as false. Valid mixed-case true and
false values remain supported.
### Any related issues, documentation, discussions?
Closes apache#8239
### How was this PR tested?
Retested with Python 3.12 on Windows in a fresh detached worktree from
upstream main at `7426431337`, which includes the merged loop-completion
change apache#8938. Regression before implementation: 2 failed, 48 passed.
After implementation: 50 passed.
Generate protobufs with `bash bin/python-proto-gen.sh`, then run from
`amber`:
```text
python -m pytest src/test/python/core/util/test_virtual_identity.py src/test/python/core/storage/test_vfs_uri_factory.py -q --tb=line -p no:cacheprovider
python -m ruff check src/main/python src/test/python
python -m ruff format --check src/main/python src/test/python
```
Ruff lint and formatting pass for all 217 Python files.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex1 parent 707849a commit 154042a
2 files changed
Lines changed: 16 additions & 0 deletions
File tree
- amber/src
- main/python/core/util
- test/python/core/util
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
114 | 120 | | |
115 | 121 | | |
116 | 122 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
198 | 208 | | |
199 | 209 | | |
200 | 210 | | |
| |||
0 commit comments