Repository navigation
fix: update() with undefined/null id fails with not-found error - #1047
Merged
Merged
Conversation
repo.update(undefined, {...}) fell through to getEntityRef(id, false),
which throws "entity is undefined" for a nullish argument regardless of
the throwException flag. Callers updating by an id that turned out to be
missing got that internal error instead of the 404 "id ... not found"
they get for any other missing row.
Check for a nullish id after the tracked-entity branch, so
update(anything, trackedInstance) keeps working, and throw the same
not-found error. Covers undefined and null on the backend and undefined
through the API proxy.
Fixes remult#1001
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 108 108
Lines 17183 17184 +1
Branches 3842 3842
=======================================
+ Hits 15025 15026 +1
Misses 2158 2158 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@drakeo338 thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1001.
Calling
repo.update()with anundefinedornullid crashed with a rawentity is undefinederror instead of a clean not-found response, becauseupdatewent straight togetEntityRefwithout checking the id first. The fix adds an explicit check that throws the same not-found errorupdatealready uses for an id that doesn't match a row, so a missing/undefined id now fails the same predictable way.Verified locally:
npm testinprojects/testswent from 27 passed / 0 failed onmainto 28 passed / 0 failed with this change, the new test asserting the not-found error for bothundefinedandnullids.