Cherry-pick f399a818e: refactor: extract ios watch reply coordinator#1335
Merged
alexey-pelykh merged 1 commit intomainfrom Mar 14, 2026
Merged
Conversation
(cherry picked from commit f399a81)
alexey-pelykh
deleted the
cherry-pick/f399a818e-ios-watch-reply-coordinator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from upstream
f399a818eSummary
Extracts watch reply queue logic from
NodeAppModelinto a dedicatedWatchReplyCoordinatorclass. The new coordinator encapsulates ingestion, draining, and requeue-front operations for watch quick reply events.Conflict resolution
One hunk in
NodeAppModel.swift— fork had reformatted the error logging (inline privacy interpolation vs separate variable). Resolved by keeping fork's logging style and taking upstream's semantic change (watchReplyCoordinator.requeueFrontreplacing direct array insert).Closes #914 — commit 1/4