fix: preserve loopback ws cdp tab ops#1314
Merged
alexey-pelykh merged 1 commit intomainfrom Mar 14, 2026
Merged
Conversation
) (cherry picked from commit 9914b48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of upstream
9914b48c57.Author: steipete (thanks shrey150)
Tier: AUTO-PICK
Ensures loopback WebSocket CDP URLs are properly normalized to HTTP for JSON API endpoints (
/json/list,/json/activate,/json/close,/json/new). ExtractsnormalizeCdpHttpBaseForJsonEndpointsfrom localpw-session.tsto sharedcdp.helpers.tsexport.Conflict resolution:
CHANGELOG.md,server-context.selection.ts,server-context.tab-ops.ts: deleted in fork (selection/tab-ops were consolidated in PR Cherry-pick 75602014d: feat(browser): support direct WebSocket CDP URLs for Browserbase #1310; theirnormalizeCdpHttpBaseusage was already present viapw-session.tslocal function).pw-session.ts: import conflict — fork had removedwithNoProxyForCdpUrl; resolved by importingnormalizeCdpHttpBaseForJsonEndpointsfromcdp.helpers.tsand removing the local copy.server-context.loopback-direct-ws.test.ts: removed — depends onserver-context.remote-tab-ops.harness.tswhich doesn't exist in fork.Part of #908.