test: share status issue assertion helpers

steipete · steipete · commit 258945d4d0d8 · 2026-03-14T01:41:17.000Z
diff --git a/extensions/test-utils/status-issues.ts b/extensions/test-utils/status-issues.ts
@@ -0,0 +1,10 @@
+import { expect } from "vitest";
+
+export function expectOpenDmPolicyConfigIssue<TAccount>(params: {
+  collectIssues: (accounts: TAccount[]) => Array<{ kind?: string }>;
+  account: TAccount;
+}) {
+  const issues = params.collectIssues([params.account]);
+  expect(issues).toHaveLength(1);
+  expect(issues[0]?.kind).toBe("config");
+}
diff --git a/extensions/zalo/src/status-issues.test.ts b/extensions/zalo/src/status-issues.test.ts
@@ -1,18 +1,18 @@
 import { describe, expect, it } from "vitest";
+import { expectOpenDmPolicyConfigIssue } from "../../test-utils/status-issues.js";
 import { collectZaloStatusIssues } from "./status-issues.js";
 
 describe("collectZaloStatusIssues", () => {
   it("warns when dmPolicy is open", () => {
-    const issues = collectZaloStatusIssues([
-      {
+    expectOpenDmPolicyConfigIssue({
+      collectIssues: collectZaloStatusIssues,
+      account: {
         accountId: "default",
         enabled: true,
         configured: true,
         dmPolicy: "open",
       },
-    ]);
-    expect(issues).toHaveLength(1);
-    expect(issues[0]?.kind).toBe("config");
+    });
   });
 
   it("skips unconfigured accounts", () => {
diff --git a/extensions/zalouser/src/status-issues.test.ts b/extensions/zalouser/src/status-issues.test.ts
@@ -1,4 +1,5 @@
 import { describe, expect, it } from "vitest";
+import { expectOpenDmPolicyConfigIssue } from "../../test-utils/status-issues.js";
 import { collectZalouserStatusIssues } from "./status-issues.js";
 
 describe("collectZalouserStatusIssues", () => {
@@ -17,16 +18,15 @@ describe("collectZalouserStatusIssues", () => {
   });
 
   it("warns when dmPolicy is open", () => {
-    const issues = collectZalouserStatusIssues([
-      {
+    expectOpenDmPolicyConfigIssue({
+      collectIssues: collectZalouserStatusIssues,
+      account: {
         accountId: "default",
         enabled: true,
         configured: true,
         dmPolicy: "open",
       },
-    ]);
-    expect(issues).toHaveLength(1);
-    expect(issues[0]?.kind).toBe("config");
+    });
   });
 
   it("skips disabled accounts", () => {
