fix: tighten target error hint coverage

steipete · steipete · commit 0146345b883b · 2026-03-14T01:00:51.000Z
diff --git a/src/infra/outbound/target-errors.test.ts b/src/infra/outbound/target-errors.test.ts
@@ -19,6 +19,16 @@ describe("target error helpers", () => {
     );
   });
 
+  it("treats blank hints the same as no hint", () => {
+    expect(missingTargetMessage("Slack", "   ")).toBe("Delivering to Slack requires target");
+    expect(ambiguousTargetMessage("Discord", "general", "   ")).toBe(
+      'Ambiguous target "general" for Discord. Provide a unique name or an explicit id.',
+    );
+    expect(unknownTargetMessage("Discord", "general", "   ")).toBe(
+      'Unknown target "general" for Discord.',
+    );
+  });
+
   it("formats ambiguous and unknown target messages with labeled hints", () => {
     expect(ambiguousTargetMessage("Discord", "general")).toBe(
       'Ambiguous target "general" for Discord. Provide a unique name or an explicit id.',
diff --git a/src/infra/outbound/target-errors.ts b/src/infra/outbound/target-errors.ts
@@ -23,8 +23,9 @@ export function unknownTargetError(provider: string, raw: string, hint?: string)
 }
 
 function formatTargetHint(hint?: string, withLabel = false): string {
-  if (!hint) {
+  const normalized = hint?.trim();
+  if (!normalized) {
     return "";
   }
-  return withLabel ? ` Hint: ${hint}` : ` ${hint}`;
+  return withLabel ? ` Hint: ${normalized}` : ` ${normalized}`;
 }

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,9 @@ export function unknownTargetError(provider: string, raw: string, hint?: string)`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`function formatTargetHint(hint?: string, withLabel = false): string {`
`26`		`- if (!hint) {`
	`26`	`+ const normalized = hint?.trim();`
	`27`	`+ if (!normalized) {`
`27`	`28`	`return "";`
`28`	`29`	`}`
`29`		- return withLabel ? ` Hint: ${hint}` : ` ${hint}`;
	`30`	+ return withLabel ? ` Hint: ${normalized}` : ` ${normalized}`;
`30`	`31`	`}`