Repository navigation
Commit 27ddf35
committed
fix: end the turn when a permission is rejected with feedback
A reject sent WITH a message produces PermissionV1.CorrectedError, but
failToolCall only blocked the loop on PermissionV1.RejectedError. So a
reject that carried feedback never ended the turn, regardless of
experimental.continue_loop_on_deny: the model received the feedback as a
tool error and could immediately retry the same call and re-ask, looping
tool-call and permission-ask events without user-visible progress.
This is the harness loop from anomalyco#31108 as observed via the v1 SDK: kimaki's
permission-timeout auto-reject always replies with a message, so its
rejections were CorrectedError and never stopped the loop. Reproduced on
unpatched dev: 6 queued identical denied retries all executed (7 LLM
calls). With this fix the first reject ends the turn (1 LLM call).
A reject is the user or a plugin saying no; the turn must end by default,
message or not. The feedback is recorded on the errored tool part, so the
model reads it on the next turn, or immediately when
continue_loop_on_deny is true.
Static ruleset denies (PermissionV1.DeniedError) still do not block:
they are routine (subagent tool restrictions) and the model should see
the error and adapt.
Tests:
- rejected permission with feedback blocks loop by default (fails on
unpatched dev: 7 calls instead of 1)
- rejected permission with feedback continues loop when
continue_loop_on_deny is true, and the model sees the feedback text
Fixes anomalyco#31108
Session: ses_15eee3980ffe5eK2RPweao3nyU1 parent 6417797 commit 27ddf35
2 files changed
Lines changed: 105 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
246 | 253 | | |
247 | 254 | | |
248 | | - | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
249 | 260 | | |
250 | 261 | | |
251 | 262 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2290 | 2290 | | |
2291 | 2291 | | |
2292 | 2292 | | |
2293 | | - | |
| 2293 | + | |
2294 | 2294 | | |
2295 | 2295 | | |
2296 | 2296 | | |
2297 | 2297 | | |
2298 | 2298 | | |
2299 | 2299 | | |
2300 | | - | |
| 2300 | + | |
2301 | 2301 | | |
2302 | 2302 | | |
2303 | 2303 | | |
| |||
2422 | 2422 | | |
2423 | 2423 | | |
2424 | 2424 | | |
| 2425 | + | |
| 2426 | + | |
| 2427 | + | |
| 2428 | + | |
| 2429 | + | |
| 2430 | + | |
| 2431 | + | |
| 2432 | + | |
| 2433 | + | |
| 2434 | + | |
| 2435 | + | |
| 2436 | + | |
| 2437 | + | |
| 2438 | + | |
| 2439 | + | |
| 2440 | + | |
| 2441 | + | |
| 2442 | + | |
| 2443 | + | |
| 2444 | + | |
| 2445 | + | |
| 2446 | + | |
| 2447 | + | |
| 2448 | + | |
| 2449 | + | |
| 2450 | + | |
| 2451 | + | |
| 2452 | + | |
| 2453 | + | |
| 2454 | + | |
| 2455 | + | |
| 2456 | + | |
| 2457 | + | |
| 2458 | + | |
| 2459 | + | |
| 2460 | + | |
| 2461 | + | |
| 2462 | + | |
| 2463 | + | |
| 2464 | + | |
| 2465 | + | |
| 2466 | + | |
| 2467 | + | |
| 2468 | + | |
| 2469 | + | |
| 2470 | + | |
| 2471 | + | |
| 2472 | + | |
| 2473 | + | |
| 2474 | + | |
| 2475 | + | |
| 2476 | + | |
| 2477 | + | |
| 2478 | + | |
| 2479 | + | |
| 2480 | + | |
| 2481 | + | |
| 2482 | + | |
| 2483 | + | |
| 2484 | + | |
| 2485 | + | |
| 2486 | + | |
| 2487 | + | |
| 2488 | + | |
| 2489 | + | |
| 2490 | + | |
| 2491 | + | |
| 2492 | + | |
| 2493 | + | |
| 2494 | + | |
| 2495 | + | |
| 2496 | + | |
| 2497 | + | |
| 2498 | + | |
| 2499 | + | |
| 2500 | + | |
| 2501 | + | |
| 2502 | + | |
| 2503 | + | |
| 2504 | + | |
| 2505 | + | |
| 2506 | + | |
| 2507 | + | |
| 2508 | + | |
| 2509 | + | |
| 2510 | + | |
0 commit comments