Fix NPE in jline3 Example as ConfigurationPath cannot be null anymore #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkop
requested changes
Nov 12, 2023
Owner
remkop
left a comment
remkop
left a comment
There was a problem hiding this comment.
That looks good.
Can you also update the picocli-shell-jline3/README.md file, which shows the same code?
Thank you!
Contributor
Author
|
Sure thing. Done |
remkop
approved these changes
Nov 12, 2023
remkop
added
type: bug 🐛
theme: shell
Owner
|
Merged. Thank you for the contribution! |
remkop
added a commit
that referenced
this pull request
Nov 12, 2023
vorburger
added a commit
to vorburger/picocli
that referenced
this pull request
Dec 15, 2023
It's broken (all red) on https://github.com/remkop/picocli/actions. remkop#2148 broke it.
This was referenced Dec 15, 2023
Merged
Closed
vorburger
added a commit
to vorburger/picocli
that referenced
this pull request
Dec 15, 2023
It's broken (all red) on https://github.com/remkop/picocli/actions. remkop#2148 broke it.
remkop
pushed a commit
that referenced
this pull request
Dec 16, 2023
It's broken (all red) on https://github.com/remkop/picocli/actions. #2148 broke it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigurationPath cannot be null anymore since commit 9706ead in jline3. An Objects.requireNonNull check now requires a valid ConfigurationPath.