Subcommand suggestions #2027
Merged
Subcommand suggestions #2027
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still fails due to a deprecation warning related to System::setSecurityManager. Sorry - I'm not familiar enough with Java to know what should be done about it.
remkop
added
type: enhancement ✨
theme: usagehelp
Owner
|
I do see one failing test: Can you take a look? |
This time I've actually fixed the tests. Previously I mistook the deprecation warning for the reason the tests failed.
Contributor
Author
|
Ah yes, I didn't understand the test framework's results. Anyway, it should be fixed now. |
remkop
approved these changes
May 20, 2023
Owner
|
Merged. |
remkop
added a commit
that referenced
this pull request
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #2026