Skip to content

Conversation

@auricgoldfinger
Copy link
Contributor

jline3 version 3.18 causes several problems in combination with Jansi 2.3.2. Solution is to upgrade jline3 to 3.19

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #1371 (431600a) into master (38909dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1371   +/-   ##
=========================================
  Coverage     93.75%   93.75%           
  Complexity      474      474           
=========================================
  Files             2        2           
  Lines          6968     6968           
  Branches       1872     1872           
=========================================
  Hits           6533     6533           
  Misses          147      147           
  Partials        288      288           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38909dc...431600a. Read the comment docs.

@remkop remkop merged commit 6e90bea into remkop:master May 5, 2021
@remkop remkop added this to the 4.6.2 milestone May 5, 2021
@remkop remkop added type: dependency 📚 theme: shell An issue or change related to interactive (JLine) applications labels May 5, 2021
@remkop remkop linked an issue May 5, 2021 that may be closed by this pull request
remkop added a commit that referenced this pull request May 5, 2021
@remkop
Copy link
Owner

remkop commented May 5, 2021

Merged.
Thank you for the pull request.
I updated the release notes, and this will be included in the next picocli release.

Thank you for the contribution!

@auricgoldfinger auricgoldfinger deleted the upgrade-jline3 branch May 6, 2021 08:09
MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…"ReadConsoleInputW failed: Incorrect function" error
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…o avoid "ReadConsoleInputW failed: Incorrect function" error"

This reverts commit 24ef290.
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
…o avoid "ReadConsoleInputW failed: Incorrect function" error"

This reverts commit 24ef290.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme: shell An issue or change related to interactive (JLine) applications type: dependency 📚

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReadConsoleInputW failed after upgrade to jansi 2.3.2

2 participants