fix shape/dtype/storage inference. #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reminisce
reviewed
Jun 6, 2018
src/operator/subgraph/subgraph_op.cc
Outdated
| const std::vector<uint32_t>& input_nids = idx_g.input_nodes(); | ||
|
|
||
| // Put the input and output shapes to the shape vector. | ||
| nnvm::ShapeVector shapes(idx_g.num_nodes()); |
Owner
There was a problem hiding this comment.
You are populating known shapes with entry ids. I think this one should be allocated with size equal to idx_g.num_node_entries() and attache attribute shape to the graph.
reminisce
pushed a commit
that referenced
this pull request
Jun 6, 2018
* update tests. * fix shape/dtype/storage inference. * fix.
reminisce
pushed a commit
that referenced
this pull request
Jun 6, 2018
* update tests. * fix shape/dtype/storage inference. * fix.
reminisce
pushed a commit
that referenced
this pull request
Jun 8, 2018
* update tests. * fix shape/dtype/storage inference. * fix.
reminisce
pushed a commit
that referenced
this pull request
Jun 9, 2018
* update tests. * fix shape/dtype/storage inference. * fix.
reminisce
pushed a commit
that referenced
this pull request
Jun 13, 2018
* update tests. * fix shape/dtype/storage inference. * fix.
reminisce
pushed a commit
that referenced
this pull request
Jun 20, 2018
* update tests. * fix shape/dtype/storage inference. * fix.
reminisce
pushed a commit
that referenced
this pull request
Aug 1, 2019
* Added tutorial for FIT API * Added tests for Fit API tutorial * Updated index.md for the new tutorial to show up * Addressed PR feedback * Addressed PR feedback * Removed spurious comment for Py2 and Py3 compatibility * Address PR feedback * Addressed PR feedback * Fixed typo * Added example to showcase custom event handler * Fixed imports as estimator moved to contrib package * Added a side note to inform about estimator reference being updated by the handlers * Corrected typo * update tutorial * address comments * new line * fix import * fix cached graph * fix import * address comments * fix doc gen * add softmax * add to website index * fix doc string * Fix doc gen (#12) * fix warining * fix test * fix * fix * fix print * fix test (#13) * fix warning (#14) * fix href (#15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments