Skip to content

Conversation

@zheng-da
Copy link

@zheng-da zheng-da commented Jun 1, 2018

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@reminisce reminisce merged commit 46d5fc7 into reminisce:subgraph_op Jun 2, 2018
reminisce pushed a commit that referenced this pull request Jun 6, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
reminisce pushed a commit that referenced this pull request Jun 6, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
reminisce pushed a commit that referenced this pull request Jun 8, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
reminisce pushed a commit that referenced this pull request Jun 9, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
reminisce pushed a commit that referenced this pull request Jun 13, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
reminisce pushed a commit that referenced this pull request Jun 20, 2018
* remove SubgraphOperator.

* change the interface of SubgraphSelector.
reminisce pushed a commit that referenced this pull request Aug 1, 2019
* Added tutorial for FIT API

* Added tests for Fit API tutorial

* Updated index.md for the new tutorial to show up

* Addressed PR feedback

* Addressed PR feedback

* Removed spurious comment for Py2 and Py3 compatibility

* Address PR feedback

* Addressed PR feedback

* Fixed typo

* Added example to showcase custom event handler

* Fixed imports as estimator moved to contrib package

* Added a side note to inform about estimator reference being updated by the handlers

* Corrected typo

* update tutorial

* address comments

* new line

* fix import

* fix cached graph

* fix import

* address comments

* fix doc gen

* add softmax

* add to website index

* fix doc string

* Fix doc gen (#12)

* fix warining

* fix test

* fix

* fix

* fix print

* fix test (#13)

* fix warning (#14)

* fix href (#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants