Conversation
This comment has been minimized.
This comment has been minimized.
Member
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
Thanks @pd4d10!
Typing additions are welcome!
A pattern we've been following throughout unified and remark is adding typings along side type tests and dtslint.
Having these solves three problems: It ensures the types are compatible with unified, it describes what versions of typescript are supported, and the tests double as examples for future reference.
Another recent typings PR to a remark project gives a good example of dtslint and type tests setup remarkjs/remark-html#32
Contributor
Author
|
@ChristianMurphy Thanks! Updated |
Co-authored-by: Christian Murphy <[email protected]>
ChristianMurphy
approved these changes
Jul 28, 2020
ChristianMurphy
added
☂️ area/types
Murderlon
approved these changes
Jul 28, 2020
Rokt33r
approved these changes
Jul 29, 2020
wooorm
approved these changes
Jul 30, 2020
Member
|
Thanks @pd4d10! Released in 2.0.0! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We are using several libs of remark and rehype ecosystem in TypeScript projects. This PR adds the type definition.
If accepted I'm glad to add types for other libs too.