Add remark-code-title to list of plugins#1076
Merged
wooorm merged 1 commit intoremarkjs:mainfrom Dec 26, 2022
kevinzunigacuellar:patch-1
Merged
Add remark-code-title to list of plugins#1076wooorm merged 1 commit intoremarkjs:mainfrom kevinzunigacuellar:patch-1
remark-code-title to list of plugins#1076wooorm merged 1 commit intoremarkjs:mainfrom
kevinzunigacuellar:patch-1
Conversation
Signed-off-by: Kevin Zuniga Cuellar <[email protected]>
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
🤞 phase/open
kevinzunigacuellar
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 901 907 +6
=========================================
+ Hits 901 907 +6
Continue to review full report at Codecov.
|
remcohaszing
approved these changes
Nov 25, 2022
Member
|
Hey! Congrats on making your plugin :) I think it can be better though: you should not inject strings of HTML into the AST. The return value of |
Contributor
Author
|
Hello @wooorm, thanks a lot for taking the time to give some feedback. I agree, injecting strings feels a bit hacky. I will update this using the mdast-hast util. I will also explore the rehype plugin route but since the package is already published I will start that in a fresh repo. Again thanks a lot for the constructive feedback 🙌 |
Contributor
Author
|
hello @wooorm sorry to bother you again. I applied the requested changes except for the |
ChristianMurphy
approved these changes
Nov 26, 2022
Member
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
Nice! Thanks for sharing.
An aside, for TypeScript + ESM, you may need "type": "module" in package.json, see https://2ality.com/2021/06/typescript-esm-nodejs.html for a guide on publishing ESM packages with TS.
Contributor
Author
Thanks, I completely missed that |
Contributor
Author
fixed in version Thanks again for the feedback. I am very new to publishing npm packages. |
wooorm
approved these changes
Dec 26, 2022
wooorm
changed the title
remark-code-title to list of plugins
Member
|
Thanks! :) |
This comment has been minimized.
This comment has been minimized.
tylersmalley
referenced
this pull request
in tailscale-dev/tailscale-dev
Jun 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [remark](https://remark.js.org) ([source](https://togithub.com/remarkjs/remark)) | [`^14.0.2` -> `^14.0.3`](https://renovatebot.com/diffs/npm/remark/14.0.2/14.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>remarkjs/remark</summary> ### [`v14.0.3`](https://togithub.com/remarkjs/remark/releases/tag/14.0.3) [Compare Source](https://togithub.com/remarkjs/remark/compare/14.0.2...14.0.3) ##### Misc - Rerelease types for changes in TypeScript [https://github.com/remarkjs/remark/issues/1162](https://togithub.com/remarkjs/remark/issues/1162)1162 - [`f6bd64e`](https://togithub.com/remarkjs/remark/commit/f6bd64e6) Refactor `tsconfig`s for perf and strictness - [`bb4c814`](https://togithub.com/remarkjs/remark/commit/bb4c8143) Add improved docs on what this project is by [@​BeLi4L](https://togithub.com/BeLi4L) in [https://github.com/remarkjs/remark/pull/1147](https://togithub.com/remarkjs/remark/pull/1147) - [`bec44aa`](https://togithub.com/remarkjs/remark/commit/bec44aa0) Update `tsconfig.json` to use node16 module resolution by [@​ChristianMurphy](https://togithub.com/ChristianMurphy) in [https://github.com/remarkjs/remark/pull/1106](https://togithub.com/remarkjs/remark/pull/1106) - [`f07f413`](https://togithub.com/remarkjs/remark/commit/f07f413f) Add `ignore-scripts` to `.npmrc` by [@​ChristianMurphy](https://togithub.com/ChristianMurphy) in [https://github.com/remarkjs/remark/pull/1103](https://togithub.com/remarkjs/remark/pull/1103) - [`134ece2`](https://togithub.com/remarkjs/remark/commit/134ece2b) Update Actions by [@​ChristianMurphy](https://togithub.com/ChristianMurphy) in [https://github.com/remarkjs/remark/pull/1070](https://togithub.com/remarkjs/remark/pull/1070) - [`974f893`](https://togithub.com/remarkjs/remark/commit/974f8936) Fix internal types for TS 4.9 ##### Plugins - [`1e488d0`](https://togithub.com/remarkjs/remark/commit/1e488d0b) Add `remark-ins` to list of plugins by [@​talatkuyuk](https://togithub.com/talatkuyuk) in [https://github.com/remarkjs/remark/pull/1129](https://togithub.com/remarkjs/remark/pull/1129) - [`e456dc5`](https://togithub.com/remarkjs/remark/commit/e456dc5b) Add `remark-flexible-markers` to list of plugins by [@​talatkuyuk](https://togithub.com/talatkuyuk) in [https://github.com/remarkjs/remark/pull/1126](https://togithub.com/remarkjs/remark/pull/1126) - [`42114fc`](https://togithub.com/remarkjs/remark/commit/42114fc6) Add `remark-flexible-paragraphs` to list of plugins by [@​talatkuyuk](https://togithub.com/talatkuyuk) in [https://github.com/remarkjs/remark/pull/1120](https://togithub.com/remarkjs/remark/pull/1120) - [`6aa638a`](https://togithub.com/remarkjs/remark/commit/6aa638ab) Add `remark-flexible-containers` to list of plugins by [@​talatkuyuk](https://togithub.com/talatkuyuk) in [https://github.com/remarkjs/remark/pull/1112](https://togithub.com/remarkjs/remark/pull/1112) - [`20e7543`](https://togithub.com/remarkjs/remark/commit/20e75435) Add `remark-flexible-code-titles` to list of plugins by [@​talatkuyuk](https://togithub.com/talatkuyuk) in [https://github.com/remarkjs/remark/pull/1108](https://togithub.com/remarkjs/remark/pull/1108) - [`32d6948`](https://togithub.com/remarkjs/remark/commit/32d69488) Add `remark-cloudinary-docusaurus` to list of plugins by [@​johnnyreilly](https://togithub.com/johnnyreilly) in [https://github.com/remarkjs/remark/pull/1090](https://togithub.com/remarkjs/remark/pull/1090) - [`28aa8b9`](https://togithub.com/remarkjs/remark/commit/28aa8b9a) update tests for changes in `mdast-util-to-markdown` - [`9af1a87`](https://togithub.com/remarkjs/remark/commit/9af1a876) Add `remark-code-title` to list of plugins by [@​kevinzunigacuellar](https://togithub.com/kevinzunigacuellar) in [https://github.com/remarkjs/remark/pull/1076](https://togithub.com/remarkjs/remark/pull/1076) - [`0d1eb09`](https://togithub.com/remarkjs/remark/commit/0d1eb09a) Add 7 plugins to list of plugins by [@​Xunnamius](https://togithub.com/Xunnamius) in [https://github.com/remarkjs/remark/pull/1064](https://togithub.com/remarkjs/remark/pull/1064) - [`c7e8171`](https://togithub.com/remarkjs/remark/commit/c7e81713) Remove deprecated `remark-jargon` by [@​LunaticMuch](https://togithub.com/LunaticMuch) in [https://github.com/remarkjs/remark/pull/1059](https://togithub.com/remarkjs/remark/pull/1059) **Full Changelog**: remarkjs/remark@14.0.2...14.0.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/tailscale-dev/tailscale-dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS44Ny4xIiwidXBkYXRlZEluVmVyIjoiMzUuODcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 6, 2024
](https://renovatebot.com){kind=link}
This was referenced Sep 9, 2024
Open
Open
This was referenced Sep 16, 2024
Open
Open
Open
This was referenced Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Zuniga Cuellar [email protected]
Initial checklist
Description of changes
Add
remark-code-titleplugin to list of plugins