Use pre-determined descriptor length as minimum #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
pushed a commit
to adafruit/CircuitPython_Community_Bundle
that referenced
this pull request
Sep 19, 2025
Updating https://github.com/relic-se/CircuitPython_USB_Host_Descriptor_Parser to 1.0.1 from 1.0.0: > Merge pull request relic-se/CircuitPython_USB_Host_Descriptor_Parser#1 from relic-se/descriptor-length-check Updating https://github.com/relic-se/CircuitPython_USB_Host_Gamepad to 1.1.0 from 1.0.0: > Merge pull request relic-se/CircuitPython_USB_Host_Gamepad#5 from relic-se/ds4 > Merge pull request relic-se/CircuitPython_USB_Host_Gamepad#4 from relic-se/port-debug > Merge pull request relic-se/CircuitPython_USB_Host_Gamepad#2 from relic-se/events-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered that some odd devices may report endpoint descriptors with longer lengths. I'm not sure what the extra data is used for, but it was causing
ValueErrorexceptions because it did not match the standard sizing. I've instead made the standard descriptor length a minimum to allow for this.The tested device was a wired PlayStation DUALSHOCK 4 controller which was reporting endpoint descriptors with a length of 9 bytes.