fix: empty template when prs all are excluded by labels (#1429)

Bledai · cchanche · web-flow · commit 4a661702d65a · 2026-03-14T18:00:54.000+01:00
* Fix: Move changelog empty check after categorization for accuracy

* chore: add tests and update build

---------

Co-authored-by: Clément Chanchevrier &lt;clement.chanchevrier@gmail.com&gt;
diff --git a/badges/coverage.svg b/badges/coverage.svg
@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="119" height="20" role="img" aria-label="Coverage: 90.31%"><title>Coverage: 90.31%</title><linearGradient id="s" x2="0" y2="100%"><stop offset="0" stop-color="#bbb" stop-opacity=".1"/><stop offset="1" stop-opacity=".1"/></linearGradient><clipPath id="r"><rect width="119" height="20" rx="3" fill="#fff"/></clipPath><g clip-path="url(#r)"><rect width="66" height="20" fill="#555"/><rect x="66" width="53" height="20" fill="#4c1"/><rect width="119" height="20" fill="url(#s)"/></g><g fill="#fff" text-anchor="middle" font-family="Verdana,Geneva,DejaVu Sans,sans-serif" font-size="11"><text x="33" y="15" fill="#010101" fill-opacity=".3">Coverage</text><text x="33" y="14">Coverage</text><text x="93" y="15" fill="#010101" fill-opacity=".3">90.31%</text><text x="93" y="14">90.31%</text></g></svg>
+<svg xmlns="http://www.w3.org/2000/svg" width="119" height="20" role="img" aria-label="Coverage: 90.34%"><title>Coverage: 90.34%</title><linearGradient id="s" x2="0" y2="100%"><stop offset="0" stop-color="#bbb" stop-opacity=".1"/><stop offset="1" stop-opacity=".1"/></linearGradient><clipPath id="r"><rect width="119" height="20" rx="3" fill="#fff"/></clipPath><g clip-path="url(#r)"><rect width="66" height="20" fill="#555"/><rect x="66" width="53" height="20" fill="#4c1"/><rect width="119" height="20" fill="url(#s)"/></g><g fill="#fff" text-anchor="middle" font-family="Verdana,Geneva,DejaVu Sans,sans-serif" font-size="11"><text x="33" y="15" fill="#010101" fill-opacity=".3">Coverage</text><text x="33" y="14">Coverage</text><text x="93" y="15" fill="#010101" fill-opacity=".3">90.34%</text><text x="93" y="14">90.34%</text></g></svg>
diff --git a/dist/actions/drafter/run.js b/dist/actions/drafter/run.js
diff --git a/src/actions/drafter/lib/build-release-payload/generate-changelog.ts b/src/actions/drafter/lib/build-release-payload/generate-changelog.ts
@@ -19,13 +19,21 @@ export const generateChangeLog = (params: {
 }) => {
   const { pullRequests, config } = params
 
-  if (pullRequests.length === 0) {
-    return config['no-changes-template']
-  }
-
   const [uncategorizedPullRequests, categorizedPullRequests] =
     categorizePullRequests({ pullRequests, config })
 
+  const categorizedPullRequestsCount = categorizedPullRequests.reduce(
+    (sum, category) => sum + category.pullRequests.length,
+    0,
+  )
+
+  const totalPullRequestsInChangelog =
+    categorizedPullRequestsCount + uncategorizedPullRequests.length
+
+  if (totalPullRequestsInChangelog === 0) {
+    return config['no-changes-template']
+  }
+
   const changeLog: string[] = []
 
   if (uncategorizedPullRequests.length > 0) {
diff --git a/src/tests/drafter/build-release-payload.test.ts b/src/tests/drafter/build-release-payload.test.ts
@@ -191,6 +191,39 @@ describe('generate changelog', () => {
       * Adds @nullable annotations to the 1*1+2*4 test in \`tests.java\` (#0) @Happypig375"
     `)
   })
+
+  it('returns no-changes-template when no pull requests are provided', () => {
+    const changelog = generateChangeLog({
+      config,
+      pullRequests: [],
+    })
+
+    expect(changelog).toBe('* No changes')
+  })
+
+  it('returns no-changes-template when all pull requests are excluded by exclude-labels', () => {
+    const changelog = generateChangeLog({
+      config: {
+        ...config,
+        'exclude-labels': ['bug', 'feature', 'bugfix', 'dependencies'],
+      },
+      pullRequests,
+    })
+
+    expect(changelog).toBe('* No changes')
+  })
+
+  it('returns no-changes-template when no pull requests match include-labels', () => {
+    const changelog = generateChangeLog({
+      config: {
+        ...config,
+        'include-labels': ['non-existent-label'],
+      },
+      pullRequests,
+    })
+
+    expect(changelog).toBe('* No changes')
+  })
 })
 
 const pullRequests: Parameters<typeof buildReleasePayload>[0]['pullRequests'] =
