Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the ImportWizard module through two key refactoring changes: reorganizing class namespaces from Services to Support and making Data Transfer Object properties immutable using the readonly keyword.
Changes:
- Renamed namespace from
Relaticle\ImportWizard\ServicestoRelaticle\ImportWizard\Supportfor better alignment with Laravel conventions - Added
readonlyproperties to immutable Data Transfer Objects (ValueIssue, ImportPreviewResult, DateFormatResult, CompanyMatchResult, ColumnAnalysis) - Updated all import statements across application code and tests to reflect the new namespace
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app-modules/ImportWizard/src/Support/*.php | Namespace declarations updated from Services to Support for 9 support classes |
| app-modules/ImportWizard/src/Data/*.php | Added readonly to 5 immutable DTO classes; ImportSessionData correctly remains mutable |
| app-modules/ImportWizard/src/Livewire/*.php | Import statements updated to reference new Support namespace |
| app-modules/ImportWizard/src/Filament/Imports/*.php | Import statements updated to reference new Support namespace |
| app-modules/ImportWizard/src/Jobs/*.php | Import statements updated to reference new Support namespace |
| tests/Unit/Services/Import/*.php | Test import statements updated to reference new Support namespace |
| tests/Feature/Filament/App/Imports/*.php | Test import statements updated to reference new Support namespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.