chore: audit password reset workflow#189
Merged
ManukMinasyan merged 2 commits intomainfrom Mar 19, 2026
Merged
Conversation
- Replace bcrypt() with Hash::make() in admin EditUser for hashing algorithm consistency across the application - Add comprehensive password reset tests covering the full Filament forgot/reset flow: link request, valid/invalid token reset, confirmation mismatch, and authenticated redirect
Two browser tests covering the full user-facing password reset journey: - Navigate from login to forgot password, submit email, see success - Reset password via signed URL, verify new password works
There was a problem hiding this comment.
Pull request overview
Audits the password reset workflow in the Filament “app” panel by standardizing admin-set password hashing and adding automated coverage for the forgot/reset flows.
Changes:
- Add feature tests covering Filament password reset request + reset flows (valid/invalid cases).
- Add Playwright browser tests for navigating from login to password reset and completing a reset via a valid link.
- Replace
bcrypt()withHash::make()when an admin updates a user password in SystemAdmin.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Feature/Auth/PasswordResetTest.php | Adds Livewire/Filament feature tests for forgot/reset password flows and edge cases. |
| tests/Browser/Auth/PasswordResetBrowserTest.php | Adds Playwright browser tests for the critical password reset UX paths. |
| app-modules/SystemAdmin/src/Filament/Resources/UserResource/Pages/EditUser.php | Uses Hash::make() when saving an updated password in the admin edit user page. |
app-modules/SystemAdmin/src/Filament/Resources/UserResource/Pages/EditUser.php
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bcrypt()→Hash::make()in admin EditUser — ensures hashing algorithm consistency across the app. If the default hasher ever changes (e.g., Argon2), admin password resets won't silently use the wrong algorithm.Test plan
PasswordResetTesttests passSystemAdmintests still pass