chore: rename docker compose files to modern convention#160
Merged
ManukMinasyan merged 1 commit intomainfrom Feb 25, 2026
Merged
chore: rename docker compose files to modern convention#160ManukMinasyan merged 1 commit intomainfrom
ManukMinasyan merged 1 commit intomainfrom
Conversation
Production config becomes the default compose.yml so deployers no longer need to copy files. Dev config moves to compose.dev.yml with SAIL_FILES env var for explicit Sail usage.
There was a problem hiding this comment.
Pull request overview
This PR modernizes Docker Compose naming so production runs from the default compose.yml, while development/Sail uses compose.dev.yml, reducing deployment steps and aligning with current Compose conventions.
Changes:
- Add
compose.ymlas the production Docker Compose file (app + horizon + scheduler + postgres + redis). - Add
compose.dev.ymlfor Laravel Sail development. - Update docs/templates and config to reference the new filenames (
README, developer guide, issue template,.dockerignore,.editorconfig,.env.example).
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| compose.yml | Introduces production default Compose configuration. |
| compose.dev.yml | Adds Sail-oriented development Compose configuration. |
| app-modules/Documentation/resources/markdown/developer-guide.md | Removes the “copy prod compose file” step since prod is now default. |
| README.md | Updates production Docker reference to compose.yml. |
| .github/ISSUE_TEMPLATE/1-bug_report.yml | Updates Docker option label to compose.yml. |
| .env.example | Adds SAIL_FILES=compose.dev.yml for Sail selection. |
| .editorconfig | Updates compose-specific indentation section to match new filenames. |
| .dockerignore | Updates ignored compose file to the new dev filename. |
Comments suppressed due to low confidence (2)
.editorconfig:19
.editorconfigsetsindent_size = 4for bothcompose.ymlandcompose.dev.yml, butcompose.ymlin this PR is consistently indented with 2 spaces (and the repo default for*.ymlis 2). Consider scoping the 4-space override tocompose.dev.ymlonly (or reformatcompose.ymlto 4) to avoid editors auto-reformatting the production file back and forth.
[compose.{yml,dev.yml}]
indent_size = 4
.env.example:10
- Setting
SAIL_FILES=compose.dev.ymlin.env.examplemakes Sail commands pick up the dev compose file by default, but the rest of.env.exampleis not Sail/container-friendly (e.g.DB_HOST=127.0.0.1,REDIS_HOST=127.0.0.1later in the file, while the compose file expectspgsql/redisservice hostnames). Either removeSAIL_FILESfrom the default.env.example, or also adjust the default DB/Redis host values to work when running inside Sail.
# Laravel Sail Configuration
SAIL_FILES=compose.dev.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production config becomes the default compose.yml so deployers no longer need to copy files. Dev config moves to compose.dev.yml with SAIL_FILES env var for explicit Sail usage.