fix: N+1 query optimization and lazy loading prevention by ManukMinasyan · Pull Request #132 · relaticle/relaticle

ManukMinasyan · 2026-02-16T22:31:47Z

Summary

Fix query hotspots in SystemAdmin widgets and registration seeding
Enable Model::preventLazyLoading() in non-production to catch lazy loading at runtime
Eager load team relationship in all CRM Filament resources
Fix NULL order_column on seeded tasks/opportunities causing undefined Kanban board order
Simplify onboard seeding architecture

Changes

Query optimizations:

PlatformGrowthStatsWidget: replace per-table COUNT loops with UNION ALL, replace per-point sparkline queries with bucketed GROUP BY
TopTeamsTableWidget: memoize expression building with once() to prevent duplicate computation
OpportunitiesBoard: memoize stageCustomField() with once()
Registration seeding: create BulkCustomFieldValueWriter for batch custom field inserts instead of per-entity writes
CreateTeamCustomFields: batch option color updates with CASE WHEN SQL

Lazy loading prevention:

Enable Model::preventLazyLoading() in non-production environments
Eager load team in CompanyResource, PeopleResource, OpportunityResource, NoteResource, TaskResource
Eager load currentTeam + ownedTeams in SystemAdmin UserResource

Onboard seeding fixes:

Assign sequential order_column via DecimalPosition for tasks/opportunities (SortableTrait events suppressed by withoutEvents())
Fix board columnIdentifier prefix (cfv. removed)
Simplify seeder architecture: remove unused context-passing, switch to Model::withoutEvents(), add FixtureRegistry::clear()
Pass team directly to seeder to avoid redundant queries
Fix deleted_at IS NULL missing in TopTeamsTableWidget last activity expression

Tests added:

Registration tests: entity counts, relationships, custom fields, board positions
Board tests: column record placement, team isolation, card movement
Team tests: non-personal teams don't get demo data

Test plan

All tests pass across all CI shards
PHPStan clean on all changed files
Pint formatting and Rector clean

…idget

…plicate computation

…rd seeding

…tests Add missing deleted_at IS NULL to TopTeamsTableWidget's buildLastActivityExpression to exclude soft-deleted records from last activity calculation. Add upper-bound assertion to registration seeding test. Remove dump() calls from query count tests.

Replace manual property caching with PHP 8.4 once() in TopTeamsTableWidget and OpportunitiesBoard. Remove redundant docblocks and inline comments across CreateTeamCustomFields, BaseModelSeeder, and NoteSeeder per coding guidelines.

Enable Model::preventLazyLoading() in non-production environments to catch N+1 queries at runtime. Add eager loading for team relationship in all 5 CRM Filament resources and currentTeam + ownedTeams in SystemAdmin UserResource. Remove QueryCounter helper and query count tests in favor of runtime lazy loading prevention.

Copilot

Pull request overview

This PR implements comprehensive N+1 query optimizations and enables lazy loading prevention to improve application performance. The changes address production performance issues detected by Sentry, achieving significant query reductions across multiple areas of the application.

Changes:

Enabled Model::preventLazyLoading() in non-production environments to catch N+1 issues at runtime
Replaced manual property caching with PHP 8.4's once() helper for cleaner memoization
Optimized widget queries using UNION ALL and bucketed GROUP BY patterns, reducing query counts by 51-81%
Introduced BulkCustomFieldValueWriter for batch inserting custom field values during seeding
Added eager loading of team relationships in all CRM Filament resources to prevent lazy loading violations in policies

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
app/Providers/AppServiceProvider.php	Enable lazy loading prevention in non-production environments
app/Filament/Resources/*.php	Add eager loading of 'team' relationship to prevent policy violations
app-modules/SystemAdmin/src/Filament/Resources/UserResource.php	Add eager loading of currentTeam and ownedTeams
app/Filament/Pages/OpportunitiesBoard.php	Replace manual memoization with once(), cleanup imports and comments
app-modules/SystemAdmin/src/Filament/Widgets/TopTeamsTableWidget.php	Use once() for memoization, fix missing deleted_at check in last activity
app-modules/SystemAdmin/src/Filament/Widgets/PlatformGrowthStatsWidget.php	Replace per-table COUNT loops with UNION ALL, use bucketed GROUP BY for sparklines
app/Listeners/CreateTeamCustomFields.php	Batch update option colors using CASE WHEN SQL instead of loop
app-modules/OnboardSeed/src/Support/BulkCustomFieldValueWriter.php	New utility for bulk inserting custom field values
app-modules/OnboardSeed/src/Support/BaseModelSeeder.php	Integrate BulkCustomFieldValueWriter, remove redundant docblocks
app-modules/OnboardSeed/src/ModelSeeders/NoteSeeder.php	Cache personalTeamId to reduce redundant queries

Fix domain_name -> domains field code mismatch in company fixtures that silently skipped domain seeding. Fix getOptionId() using wrong property name (label -> name) causing all select fields to fall back to first option. Fix invalid stage names in opportunity fixtures. Remove lazy load of company->team in PeopleSeeder. Wrap seeding in withoutModelEvents() to skip observer queries on freshly created system entities (~52 queries eliminated).

…onboard seeding SortableTrait's creating event is suppressed by withoutEvents(), leaving order_column NULL on seeded records. Manually assign sequential positions using DecimalPosition so Kanban boards render in defined order. Also simplifies seeder architecture: remove unused context-passing pattern, eliminate redundant docblocks, fix board columnIdentifier prefix, and add FixtureRegistry::clear() for safe reuse. Adds registration and team tests.

The batched method was never released in flowforge and loaded all records without a LIMIT. Use the existing per-column approach which correctly limits results at the database level.

…ypes

- Chunk bulk inserts in BulkCustomFieldValueWriter (500 rows) to stay within PostgreSQL's parameter limit - Add SQLite fallback for TIMESTAMP literal and GREATEST in TopTeamsTableWidget for test portability - Restore {{ }} guard in processCustomFieldValues for clarity

… guidelines Replace 644-line Boost auto-generated copilot-instructions.md with a concise 130-line review-focused version. Adds tenant isolation, authorization, and data safety review rules based on actual codebase gap analysis. Removes MCP tool references and development workflow instructions irrelevant to code reviewers.

Copilot

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 4 comments.

app/Filament/Pages/OpportunitiesBoard.php

Copilot · 2026-02-17T10:37:39Z

app-modules/SystemAdmin/src/Filament/Widgets/PlatformGrowthStatsWidget.php

+    private function bucketExpression(): string
+    {
+        if (DB::getDriverName() === 'sqlite') {
+            return 'CAST((julianday("created_at") - julianday(?)) * 86400 / ? AS INTEGER)';
+        }
+
+        return 'FLOOR(EXTRACT(EPOCH FROM ("created_at" - ?::timestamp)) / ?)';


The bucket index computed by bucketExpression() can equal $points for records exactly at $end because both callers use whereBetween('created_at', [$start, $end]) (inclusive end) and the expression uses FLOOR((created_at - start) / segmentSeconds). Those rows will be dropped by the if ($idx >= 0 && $idx < $points) guard, undercounting the sparkline. Consider making the end boundary exclusive (where('created_at', '<', $end)) or clamping the computed bucket to $points - 1 in SQL (e.g. LEAST(bucket, ?) / CASE) so boundary records are counted.

app-modules/SystemAdmin/src/Filament/Widgets/PlatformGrowthStatsWidget.php

ManukMinasyan added 13 commits February 17, 2026 00:25

chore: add query counter helper and results tracking for N+1 fixes

ff6bf52

test: add query count reproduction for PlatformGrowthStatsWidget

10b28e8

fix: replace N+1 count queries with UNION ALL in PlatformGrowthStatsW…

3e63739

…idget

test: add query count reproduction for TopTeamsTableWidget

0f5b03d

fix: memoize expression building in TopTeamsTableWidget to prevent du…

d36f6ee

…plicate computation

test: add query count reproduction for OpportunitiesBoard

7b21f05

fix: memoize stageCustomField() in OpportunitiesBoard

316a0cf

test: add query count reproduction for registration seeding

6c97904

fix: batch option color updates in CreateTeamCustomFields

824fbc5

fix: add bulk custom field value writer to eliminate N+1 during onboa…

e2aacd7

…rd seeding

Copilot AI review requested due to automatic review settings February 16, 2026 22:31

Copilot started reviewing on behalf of ManukMinasyan February 16, 2026 22:32 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

ManukMinasyan added 7 commits February 17, 2026 02:49

fix: use per-column getBoardRecords in board tests

fc1e37f

The batched method was never released in flowforge and loaded all records without a LIMIT. Use the existing per-column approach which correctly limits results at the database level.

fix: apply rector rules for type-safe null check and closure return t…

8e2b41b

…ypes

fix: add parameter types to closures for type coverage

fc1c71d

ManukMinasyan requested a review from Copilot February 17, 2026 10:27

Copilot started reviewing on behalf of ManukMinasyan February 17, 2026 10:28 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

ManukMinasyan added 2 commits February 17, 2026 19:02

fix: use string id type in examples and restore deferFilters note

9a67448

fix: use positional GROUP BY for postgresql compatibility

5beedc2

ManukMinasyan merged commit 71c8b90 into main Feb 17, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: N+1 query optimization and lazy loading prevention#132

fix: N+1 query optimization and lazy loading prevention#132
ManukMinasyan merged 22 commits intomainfrom
fix/n-plus-one-query-optimization

ManukMinasyan commented Feb 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ManukMinasyan commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ManukMinasyan commented Feb 16, 2026 •

edited

Loading