Refactor/import wizard separate skipped column#108
Merged
ManukMinasyan merged 10 commits into3.xfrom Jan 27, 2026
Merged
Conversation
add dedicated 'skipped' column to track value-level skips instead of using magic string in corrections column. this fixes filter counts showing incorrect values for skipped and modified items.
- Configure blank_issues_enabled: false to require template use - Redirect feature requests and support to GitHub Discussions - Add bug report template with environment details collection - Add task/improvement template for technical work - Auto-add new issues to Roadmap project - Auto-label issues by type (area:bug, area:dev)
- Remove task template (internal use only) - Add Discord community link to issue template config
- Bug reports now get 'bug' and 'unconfirmed' labels automatically - GitHub will auto-set Type field to Bug based on label
- add SortField and SortDirection enums for configurable sorting - add two-section sort dropdown (field + direction) with checkmarks - implement async column validation with ValidateColumnJob - add ImportValueValidator for centralized value validation - show validation progress bar while processing columns - display error indicators on columns with validation issues - remove hardcoded sort order from uniqueValuesFor scope
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive refactoring of the ImportWizard's value review and validation system, with a major architectural change to separate column-level value skipping from row-level import skipping.
Changes:
- Introduces asynchronous column validation using queued jobs with batch tracking and progress indication
- Adds support for number format selection (point vs comma decimal separators) alongside the existing date format functionality
- Implements granular column-value skipping (marking specific values as null) distinct from row-level skipping
- Adds sorting controls for review values (by count or value, ascending/descending)
Reviewed changes
Copilot reviewed 26 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ImportValueValidator.php | New centralized validator for date, number, and choice field values with caching |
| ValidateColumnJob.php | New background job for async column validation using temporary tables for performance |
| ImportStore.php | Major refactoring: adds validation batch management, value skipping, correction management with batch SQL updates |
| ImportRow.php | Adds skipped column/property and updates scopes to filter by column-specific validation/corrections/skipped state |
| ReviewStep.php | Adds format selection, sorting, batch progress tracking, and methods for corrections/skipping |
| NumberFormat.php | New enum for decimal separator formats with parsing and formatting methods |
| DateFormat.php | Enhanced with parsing methods and UI option generation |
| SortField.php, SortDirection.php | New enums for sorting controls |
| ImportNumberRule.php | New validation rule for number format validation |
| ImportChoiceRule.php | Parameter renamed from $isMulti to $isMultiChoice for clarity |
| ColumnData.php | Adds numberFormat property and methods for format updates and value hashing |
| RelationshipField.php | Refactored to use DRY cloneWith method for immutable updates |
| Blade templates | Updated UI for format selection, sorting, loading states, and column-level value actions |
| CsvReaderFactoryTest.php | Deleted (86 lines of tests removed without replacement) |
| .github templates | Added issue templates for bug reports and community links |
| composer.lock, package-lock.json | Updated dependencies (Filament 5.0 → 5.1, Livewire 4.0.2 → 4.0.3, etc.) |
| wizard.js | Added goToStep method for direct step navigation |
| notifications.js | Added type check before calling animation function |
| @if ($showUndo) | ||
| <button | ||
| wire:click.stop.preserve-scroll="updateMappedValue({{ Js::from($selectedColumn) }}, {{ Js::from($rawValue) }}, {{ Js::from($rawValue) }})" | ||
| wire:click.stop.preserve-scroll="undoCorrection({{ Js::from($rawValue) }}, {{ Js::from($rawValue) }})" |
There was a problem hiding this comment.
The undoCorrection method is being called with 2 parameters (both rawValue), but the method signature only accepts 1 parameter. The second parameter should be removed from this call.
Suggested change
| wire:click.stop.preserve-scroll="undoCorrection({{ Js::from($rawValue) }}, {{ Js::from($rawValue) }})" | |
| wire:click.stop.preserve-scroll="undoCorrection({{ Js::from($rawValue) }})" |
| UPDATE import_rows | ||
| SET validation = json_set(COALESCE(validation, '{}'), ?, ?) | ||
| WHERE json_extract(raw_data, ?) = ? | ||
| ", [$jsonPath, $error, $jsonPath, $rawValue]); |
There was a problem hiding this comment.
When clearing the skipped flag and the value is valid (error is null), the validation error should also be cleared from the database. Currently, only invalid values get their validation updated. Add an else clause to remove the validation error when the value is valid, similar to the pattern used in clearCorrection method (lines 645-650).
Suggested change
| ", [$jsonPath, $error, $jsonPath, $rawValue]); | |
| ", [$jsonPath, $error, $jsonPath, $rawValue]); | |
| } else { | |
| // Batch clear validation error when the raw value is now valid | |
| $this->connection()->statement(" | |
| UPDATE import_rows | |
| SET validation = NULLIF( | |
| json_remove(COALESCE(validation, '{}'), ?), | |
| '{}' | |
| ) | |
| WHERE json_extract(raw_data, ?) = ? | |
| ", [$jsonPath, $jsonPath, $rawValue]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.