rehype-parse: bump parse5 from ^6.0.0 to ^7.0.0#113
Closed
milahu wants to merge 1 commit intorehypejs:mainfrom
Closed
rehype-parse: bump parse5 from ^6.0.0 to ^7.0.0#113milahu wants to merge 1 commit intorehypejs:mainfrom
milahu wants to merge 1 commit intorehypejs:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
milahu
force-pushed
the
rehype-parse-bump-parse5
branch
from
662137d to
55830fa
Compare
Author
|
some more imports need fixing → draft since ESM, package authors can hide internal files ... |
This was referenced Oct 17, 2022
|
Before this gets merged in, is there any workaround for this error? |
Author
|
ideally use public exports - import { Parser } from "parse5/lib/parser/index.js"
+ import { Parser } from "parse5"
- import { ERR } from "parse5/lib/common/error-codes.js"
+ import { ErrorCodes } from "parse5"workaround: use dynamic imports for private exports @bradgarropy feel free to make a new PR closing as abandoned |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
wooorm
added
👎 phase/no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
update parse5
we already use version 7 in hast-util-from-parse5
https://github.com/syntax-tree/hast-util-from-parse5/blob/fa0be0e589a42b1373d80f290912f6c39bf8731a/package.json#L48