Fix SendDeathMessage kill rarity flags and transform to VFUNC#943
Merged
s1lentq merged 5 commits intorehlds:masterfrom May 8, 2024
Merged
Fix SendDeathMessage kill rarity flags and transform to VFUNC#943s1lentq merged 5 commits intorehlds:masterfrom
SendDeathMessage kill rarity flags and transform to VFUNC#943s1lentq merged 5 commits intorehlds:masterfrom
Conversation
This flag was never valid in "SendDeathMessage" hook
FEDERICOMB96
changed the title
SendDeathMessage kill rarity flags and transform to VFUNCSendDeathMessage kill rarity flags and transform to VFUNC
Contributor
Can you describe these problems? |
Contributor
Author
Modify Replace |
yohimik
pushed a commit
to yohimik/ReGameDLL_CS
that referenced
this pull request
Jun 5, 2025
…ds#943) * implement VFUNC to `SendDeathMessage` * fix use KILLRARITY_HEADSHOT flag instead of member * fix rare crash when pAssister is nullptr * fix KILLRARITY_DOMINATION_BEGAN flag This flag was never valid in "SendDeathMessage" hook * set iDeathMessageFlags before call function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves some problems detected during the testing of the hook "RG_CSGameRules_SendDeathMessage" and is totally linked to rehlds/ReAPI#305