FIX: NavArea::ComputeApproachAreas() hang during *.nav file generation#913
Merged
FIX: NavArea::ComputeApproachAreas() hang during *.nav file generation#913
NavArea::ComputeApproachAreas() hang during *.nav file generation#913Conversation
CNavArea::ComputeApproachAreas(): fix hang on *.nav generatingNavArea::ComputeApproachAreas() hang during *.nav file generation
yohimik
pushed a commit
to yohimik/ReGameDLL_CS
that referenced
this pull request
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @CH3L74 for finding the bug on zm_flood map
video: https://youtu.be/Lu0yzVpQoAE
P.S:
Very Sleepysoftware helps to find where is a bug http://www.codersnotes.com/sleepy/Fix Hang on
*.navGenerating inCNavArea::ComputeApproachAreas()Description
This PR fixes a hanging issue encountered during the generation of
*.navfiles in theCNavArea::ComputeApproachAreas()function. The problem occurred when the approach areas were being computed, causing the process to freeze under certain conditions.Changes:
Issue:
Fixes:
This fix should resolve the hang issue and improve the reliability of the navigation area generation process.