Fix: Grenade weaponbox not deploying on unarmed player#847
Merged
s1lentq merged 3 commits intorehlds:masterfrom Sep 5, 2023
Merged
Fix: Grenade weaponbox not deploying on unarmed player#847s1lentq merged 3 commits intorehlds:masterfrom
s1lentq merged 3 commits intorehlds:masterfrom
Conversation
s1lentq
approved these changes
Sep 5, 2023
Closed
yohimik
pushed a commit
to yohimik/ReGameDLL_CS
that referenced
this pull request
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to reproduce:
This commit fixes two issues:
This issue is related to weaponbox and not armoury_entity
TODO: Weaponbox gives ammo AFTER weapon is linked to player, CanDeploy depends on ammo in exhaustible weapons, we can consider this proposal as a final solution to that; or refactor the whole weaponbox behaviour.
Related to #479 but applied in a better fashion way, with explanation