Skip to content

mp_fadetoblack fade timings now depends from mp_dying_time CVar#845

Merged
wopox1337 merged 3 commits intorehlds:masterfrom
wopox1337:feature/mp_fadetoblack-support-mp_diyng_time
Jul 16, 2023
Merged

mp_fadetoblack fade timings now depends from mp_dying_time CVar#845
wopox1337 merged 3 commits intorehlds:masterfrom
wopox1337:feature/mp_fadetoblack-support-mp_diyng_time

Conversation

@wopox1337
Copy link
Member

@wopox1337 wopox1337 commented Jul 13, 2023 •
edited
Loading

  • Fix forcing 1-person view for players when mp_fadetoblack = 2;
  • Fix player blackout on server entry when mp_fadetoblack = 2;
  • Fix observer not being blinded when mp_fadetoblack = 2;
  • Fix fadetoblack message timings using new CVar mp_dying_time.

fix #501
fix #506

@wopox1337 wopox1337 added Type: 🐞 bug An error that needs fixing. Type: 🚀 enhancement Improvement or addition of a new feature. Priority: 🕒 low Low priority tasks that can be postponed for the future. labels Jul 13, 2023
@wopox1337 wopox1337 requested a review from s1lentq July 13, 2023 02:06
@wopox1337 wopox1337 self-assigned this Jul 13, 2023
wopox1337 added 2 commits July 13, 2023 18:39
@wopox1337
mp_fadetoblack 2: disable fade for observers
66c6fb8 
fiix rehlds#506
@wopox1337
Squashed commit of the following:
736c4de 
commit 54f5f91
Author: Sergey Shorokhov <[email protected]>
Date:   Fri Jul 14 17:21:08 2023 +0300

    enum style fix

commit 3f76335
Merge: 57fa3d8 606c6e2
Author: Sergey Shorokhov <[email protected]>
Date:   Fri Jul 14 05:58:05 2023 +0300

    Merge branch 'fix_fadetoblack' of https://github.com/wopox1337/ReGameDLL_CS into fix_fadetoblack

commit 57fa3d8
Author: Sergey Shorokhov <[email protected]>
Date:   Fri Jul 14 05:47:25 2023 +0300

    change fadeblack conditions

commit 5af99d4
Author: Sergey Shorokhov <[email protected]>
Date:   Fri Jul 14 05:34:13 2023 +0300

    use enum for fadetoblack values

commit 5b9bec0
Author: SergeyShorokhov <[email protected]>
Date:   Sat Jun 13 01:33:01 2020 +0300

    fix observers flash

commit 81e51dd
Author: SergeyShorokhov <[email protected]>
Date:   Fri Jun 12 13:31:43 2020 +0300

    fix naming

commit f67d6c5
Author: SergeyShorokhov <[email protected]>
Date:   Fri Jun 12 13:17:20 2020 +0300

    Observer fix (mp_forcechasecam)

commit d2bc6b8
Author: SergeyShorokhov <[email protected]>
Date:   Fri Jun 12 13:04:47 2020 +0300

    Don't blind dying players (flash grenade)

commit f7c96c8
Author: SergeyShorokhov <[email protected]>
Date:   Fri Jun 12 12:54:45 2020 +0300

    Revert message gmsgForceCam changes

commit 1be59c5
Author: Shorokhov Sergey <[email protected]>
Date:   Thu Feb 6 16:16:06 2020 +0300

    remove casts

commit b3ff0d8
Author: Shorokhov Sergey <[email protected]>
Date:   Thu Feb 6 15:46:00 2020 +0300

    Add CVar states naming

commit d7edd67
Author: Shorokhov Sergey <[email protected]>
Date:   Thu Feb 6 15:25:17 2020 +0300

    fix cvar dependencies

commit 606c6e2
Author: Sergey Shorokhov <[email protected]>
Date:   Fri Jul 14 05:47:25 2023 +0300

    change fadeblack conditions

commit bf9271b
Author: Sergey Shorokhov <[email protected]>
Date:   Fri Jul 14 05:34:13 2023 +0300

    use enum for fadetoblack values

commit 039aab8
Merge: ff7ccdf 8a18969
Author: Sergey Shorokhov <[email protected]>
Date:   Fri Jul 14 05:26:35 2023 +0300

    Merge branch 'master' into fix_fadetoblack

commit ff7ccdf
Author: SergeyShorokhov <[email protected]>
Date:   Sat Jun 13 01:33:01 2020 +0300

    fix observers flash

commit 5aa7923
Author: SergeyShorokhov <[email protected]>
Date:   Fri Jun 12 13:31:43 2020 +0300

    fix naming

commit 8fb7b8a
Author: SergeyShorokhov <[email protected]>
Date:   Fri Jun 12 13:17:20 2020 +0300

    Observer fix (mp_forcechasecam)

commit 99b8a02
Author: SergeyShorokhov <[email protected]>
Date:   Fri Jun 12 13:04:47 2020 +0300

    Don't blind dying players (flash grenade)

commit 0202ad4
Author: SergeyShorokhov <[email protected]>
Date:   Fri Jun 12 12:54:45 2020 +0300

    Revert message gmsgForceCam changes

commit 3a3da4b
Author: Shorokhov Sergey <[email protected]>
Date:   Thu Feb 6 16:27:27 2020 +0300

    fix type conversion

commit 049b02a
Author: Shorokhov Sergey <[email protected]>
Date:   Thu Feb 6 16:16:06 2020 +0300

    remove casts

commit 1268de3
Author: Shorokhov Sergey <[email protected]>
Date:   Thu Feb 6 15:46:00 2020 +0300

    Add CVar states naming

commit 7aab520
Author: Shorokhov Sergey <[email protected]>
Date:   Thu Feb 6 15:25:17 2020 +0300

    fix cvar dependencies

commit ac70614
Merge: 2694a92 b465002
Author: Shorohov Sergey <[email protected]>
Date:   Thu Feb 6 13:36:46 2020 +0300

    update from upstream

commit 2694a92
Merge: 44e7758 2eba3b1
Author: Shorokhov Sergey <[email protected]>
Date:   Thu Jan 16 15:37:16 2020 +0300

    Merge branch 'master' of https://github.com/s1lentq/ReGameDLL_CS

commit 44e7758
Merge: eaaa3fd fd06d65
Author: Shorohov Sergey <[email protected]>
Date:   Mon Dec 2 16:04:42 2019 +0300

    Merge pull request #7 from s1lentq/master

    update

commit eaaa3fd
Merge: 5307bb7 46624d9
Author: Shorohov Sergey <[email protected]>
Date:   Wed Oct 2 16:43:33 2019 +0300

    Merge pull request #6 from s1lentq/master

    Up

commit 5307bb7
Merge: e51af43 3aa9872
Author: Shorohov Sergey <[email protected]>
Date:   Tue Sep 3 15:58:57 2019 +0300

    Merge pull request #5 from s1lentq/master

    update

commit e51af43
Merge: 411a028 4d8a1b9
Author: Shorokhov Sergey <[email protected]>
Date:   Mon Sep 2 11:59:43 2019 +0300

    Merge branch 'master' of https://github.com/wopox1337/ReGameDLL_CS

commit 4d8a1b9
Merge: feae856 75bdc26
Author: Shorohov Sergey <[email protected]>
Date:   Mon Jul 29 16:40:36 2019 +0300

    Merge pull request #4 from s1lentq/master

    uptodate

commit feae856
Merge: a5283cf b669a39
Author: Shorohov Sergey <[email protected]>
Date:   Mon Jul 8 14:06:12 2019 +0300

    Merge pull request #3 from s1lentq/master

    uptodate

commit a5283cf
Merge: c8a6a4a cee63d9
Author: Shorohov Sergey <[email protected]>
Date:   Sun Jun 9 12:58:36 2019 +0300

    Merge pull request #2 from s1lentq/master

    up

commit c8a6a4a
Merge: 94f0fdb 935064c
Author: Shorohov Sergey <[email protected]>
Date:   Thu Jun 6 01:04:50 2019 +0300

    Merge pull request #1 from s1lentq/master

    update
@wopox1337 wopox1337 merged commit 9427767 into rehlds:master Jul 16, 2023
@Vaqtincha
Copy link
Contributor

Vaqtincha commented Jul 16, 2023

Наконец-то он свою жирную жопу поднял и будет начать принимать нужных (и совсем ненужных) пр 5летней давности.

@wopox1337 wopox1337 deleted the feature/mp_fadetoblack-support-mp_diyng_time branch January 1, 2024 07:52
yohimik pushed a commit to yohimik/ReGameDLL_CS that referenced this pull request Jun 5, 2025
@wopox1337 @s1lentq @yohimik
mp_fadetoblack 2 fade timings now depends from mp_dying_time CVar…
07a27f5 
… and code fixes (rehlds#845)

 Fix forcing 1-person view for players when `mp_fadetoblack = 2`;
 Fix player blackout on server entry when `mp_fadetoblack = 2`;
 Fix observer not being blinded when `mp_fadetoblack = 2`;
 Fix fadetoblack message timings using new CVar `mp_dying_time`.

fix rehlds#501
fix rehlds#506

Co-authored-by: s1lentq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1lentq s1lentq Awaiting requested review from s1lentq

Assignees

@wopox1337 wopox1337

Labels

Priority: 🕒 low Low priority tasks that can be postponed for the future. Type: 🐞 bug An error that needs fixing. Type: 🚀 enhancement Improvement or addition of a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] Observers don't blind from flash (mp_fadetoblack 2) Wrong black Screenfade on server joining (mp_fadetoblack 2)

2 participants

@wopox1337 @Vaqtincha