Skip to content

Fixed crash sometimes occurring while map analyzing for zbot navigation#844

Merged
s1lentq merged 1 commit intomasterfrom
crash-during-zbot-analyze
Sep 5, 2023
Merged

Fixed crash sometimes occurring while map analyzing for zbot navigation#844
s1lentq merged 1 commit intomasterfrom
crash-during-zbot-analyze

Conversation

@s1lentq
Copy link
Member

@s1lentq s1lentq commented Jul 13, 2023

The iterator m_analyzeIter could potentially become invalid due to the possibility of TheNavAreaList removing elements while the analysis is ongoing.
It's recommended to test the proposed fix thoroughly before merging it

@dystopm
Copy link
Contributor

dystopm commented Jul 13, 2023

Good catch

@s1lentq s1lentq merged commit e8bff71 into master Sep 5, 2023
@s1lentq s1lentq deleted the crash-during-zbot-analyze branch November 26, 2023 04:31
yohimik pushed a commit to yohimik/ReGameDLL_CS that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants