Skip to content

CZero: Fix broken Career Tasks#836

Merged
wopox1337 merged 3 commits intorehlds:masterfrom
dystopm:fix-broken-careertasks
Jul 10, 2023
Merged

CZero: Fix broken Career Tasks#836
wopox1337 merged 3 commits intorehlds:masterfrom
dystopm:fix-broken-careertasks

Conversation

@dystopm
Copy link
Contributor

@dystopm dystopm commented May 29, 2023

Close #835

  1. Code cleaning on CBasePlayer::Killed which inside calls HandleEnemyKill with wrong parameter order
  2. Changed conditions inside CCareerTask::OnEvent on hostage-related events which detects leader/follower with the unused m_target member and changed with IsFollowing method.

@wopox1337 wopox1337 self-requested a review July 10, 2023 12:44
@wopox1337 wopox1337 added Type: 🧬 bug in original GameDLL An error that could not be fixed by GameDLL. Priority: 🕒 low Low priority tasks that can be postponed for the future. labels Jul 10, 2023
@wopox1337 wopox1337 merged commit d4deabf into rehlds:master Jul 10, 2023
@dystopm dystopm deleted the fix-broken-careertasks branch July 19, 2023 16:28
yohimik pushed a commit to yohimik/ReGameDLL_CS that referenced this pull request Jun 5, 2025
* Fix HandleEnemyKill params and Hostage target detection

* Var name mistake

* Grouping more code on FIXES macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: 🕒 low Low priority tasks that can be postponed for the future. Type: 🧬 bug in original GameDLL An error that could not be fixed by GameDLL.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CZ: Career Tasks Fix with Orpheu

2 participants