Little code cleaning: g_vecAttackDir#831
Merged
wopox1337 merged 4 commits intorehlds:masterfrom Jul 11, 2023
Merged
Conversation
Member
|
There's no need to wrap in a macro p.s We shouldn't be concerned about the fact that with these minor changes we can break compatibility 3-rd party things when they use memhacks. |
Contributor
Author
Thanks for your observation, I'll keep in mind this next time 🙌 commit done now |
wopox1337
added
the
Priority: 🕒 low
…alled for testdemo)
yohimik
pushed a commit
to yohimik/ReGameDLL_CS
that referenced
this pull request
Jun 5, 2025
* Tiny code cleaning * Skip REGAMEDLL_FIXES * UTIL_BloodDrips: remove useless `direction` param * Fix test demo (RANDOM_FLOAT inside UTIL_RandomBloodVector should be called for testdemo) --------- Co-authored-by: Sergey Shorokhov <[email protected]> Co-authored-by: s1lentq <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same argument as #830 : variables used as parameters, mostly used in a old fashioned programming way and on singleplayer hlsdk branch.
Might be useless but opens mind about certain code that should be reviewed in detail.