New CVar: mp_hostages_rescued_ratio#786
Merged
wopox1337 merged 3 commits intorehlds:masterfrom Nov 24, 2022
Merged
Conversation
fl0werD
force-pushed
the
feature/fix-hostage-ratio
branch
from
f1aabcf to
4d84606
Compare
wopox1337
force-pushed
the
feature/fix-hostage-ratio
branch
from
3223bbe to
3cb47fa
Compare
wopox1337
changed the title
mp_hostages_rescued_ratio
Member
|
:D https://youtu.be/lvXW_PIqYN0 |
Contributor
|
@fl0werD @wopox1337 |
Contributor
Author
|
@RauliTop it able to be more ifdef macros, but it unreadable fine. We can also wrap more code into macros, but now it's minimal edit. |
yohimik
pushed a commit
to yohimik/ReGameDLL_CS
that referenced
this pull request
Jun 5, 2025
* Add mp_hostages_rescued_ratio cvar * Add restriction of the CVar value Co-authored-by: Sergey Shorokhov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/s1lentq/ReGameDLL_CS/blob/master/regamedll/dlls/multiplay_gamerules.cpp#L1471
This business logic does not work correctly because the code below does not consider by 50%.
https://github.com/s1lentq/ReGameDLL_CS/blob/master/regamedll/dlls/multiplay_gamerules.cpp#L1482
Adding cvar for ratio and and default value for compatibility.