Skip to content

Implement CCSEntity::FireBuckshots#651

Merged
wopox1337 merged 4 commits intorehlds:masterfrom
FEDERICOMB96:API-Implemented-CCSEntity-FireBuckshots
Aug 31, 2021
Merged

Implement CCSEntity::FireBuckshots#651
wopox1337 merged 4 commits intorehlds:masterfrom
FEDERICOMB96:API-Implemented-CCSEntity-FireBuckshots

Conversation

@FEDERICOMB96
Copy link
Contributor

No description provided.

@Vaqtincha
Copy link
Contributor

It's useless. This is the same as FireBullets.

@StevenKal
Copy link
Contributor

StevenKal commented Jun 28, 2021

Besides, this will break subfunctions (CCSPlayer*) indexes for non-recompiled third-party modules (usually, existing ReAPI modules). Major version will need a +1 boost (not much problematic if an error tells this to the users).
So if CCSEntity is touched at a moment, maybe at the occasion a specific amount of "dummy/unused functions" (like 20) could be added to avoid future breaking of the IDs of the subfunctions, only renaming + format will be changed in those dummy (virtual void CCSEntity_unused1();, etc.).

@wopox1337 wopox1337 self-assigned this Aug 31, 2021
@wopox1337 wopox1337 requested review from s1lentq and wopox1337 August 31, 2021 13:40
@wopox1337 wopox1337 added Priority: 🕒 low Low priority tasks that can be postponed for the future. Status: ✅ done The issue done and closed. Type: 🚀 enhancement Improvement or addition of a new feature. labels Aug 31, 2021
@wopox1337 wopox1337 changed the title API: Implemented CCSEntity::FireBuckshots Implement CCSEntity::FireBuckshots Aug 31, 2021
@StevenKal
Copy link
Contributor

Cool wopox! Hehe!
But please edit here (326cfbb) the "Observer_FindNextPlayer" order by putting that last hook after "Observer_SetMode", edit all the files except "observer.cpp".

@wopox1337 wopox1337 merged commit d7be271 into rehlds:master Aug 31, 2021
wopox1337 pushed a commit that referenced this pull request Aug 31, 2021
yohimik pushed a commit to yohimik/ReGameDLL_CS that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: 🕒 low Low priority tasks that can be postponed for the future. Status: ✅ done The issue done and closed. Type: 🚀 enhancement Improvement or addition of a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants