API: CSPlayer and CKnife additions + headers refactory#277
Merged
s1lentq merged 12 commits intorehlds:masterfrom Jul 15, 2023
Merged
API: CSPlayer and CKnife additions + headers refactory#277s1lentq merged 12 commits intorehlds:masterfrom
API: CSPlayer and CKnife additions + headers refactory#277s1lentq merged 12 commits intorehlds:masterfrom
Conversation
Interface was coded but never implemented. It needs tests
Implement RG_CreateWeaponBox hook
Interface was coded but never implemented. It needs tests
Contributor
Author
|
Consider this one also: #275 :) |
dystopm
changed the title
API: CSPlayer and CKnife additions + ReGameDLL API update + headers refactoryAPI: CSPlayer and CKnife additions + headers refactory
Contributor
Author
|
@s1lentq just merged master into this and updated a few lines considering the lasts additions |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
@Vaqtincha thing is, CreateWeaponBox doesn't belong to CWeaponBox class, neither a virtual or derived function of it, it just returns an object from the CWeaponBox class, it's outside class declaration/scope |
Contributor
|
then noticed. OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hook_callback.cpp/hdeclarations based onregamedll_api.h: to maintain the order of functions being added as the API is extended.Updated regamedll_api.h (version and new functions added) (rehlds/ReGameDLL_CS@eb91f92)(added in 87e4858)Some commits are really old so I'm concerned about how this old is getting this. Depending on this PR I'll be adding a bunch of new API functions, including some new natives, so I'll be glad to keep extending this in function of your approvals