Skip to content

Fix wrong native error description#236

Merged
wopox1337 merged 6 commits intorehlds:masterfrom
Nord1cWarr1or:delete-info
Dec 28, 2021
Merged

Fix wrong native error description#236
wopox1337 merged 6 commits intorehlds:masterfrom
Nord1cWarr1or:delete-info

Conversation

@Nord1cWarr1or
Copy link
Contributor

Delete wrong native error description.

@wopox1337 wopox1337 self-requested a review December 20, 2021 17:22
@wopox1337 wopox1337 added the Type: 🐞 bug An error that needs fixing. label Dec 20, 2021
@wopox1337 wopox1337 changed the title Delete wrong native error desc Fix wrong native error description Dec 20, 2021
wopox1337
wopox1337 previously approved these changes Dec 20, 2021
@wopox1337 wopox1337 dismissed their stale review December 20, 2021 17:24

is it need?

@wopox1337
Copy link
Member

wopox1337 commented Dec 20, 2021

The error does occur when the buffer handler is wrong. For this reason it is necessary to correct the error description, but not to delete it.
https://github.com/s1lentq/reapi/blob/e808d72075f5018336c15955f8d2d68e8f2cc084/reapi/src/natives/natives_common.cpp#L134-L139

@Nord1cWarr1or
Copy link
Contributor Author

@wopox1337 done.
I also added error desc in set_key_value native.

@wopox1337 wopox1337 merged commit 15aca1d into rehlds:master Dec 28, 2021
@Nord1cWarr1or Nord1cWarr1or deleted the delete-info branch March 17, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: 🐞 bug An error that needs fixing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants