rg_give_defusekit(): Add player team check#234
Merged
s1lentq merged 2 commits intorehlds:masterfrom Mar 31, 2023
Merged
Conversation
Add player team check to avoid unexpected behavior
byjumpe
reviewed
Nov 25, 2021
Fix wrong team constant
Giferns
changed the title
|
What kind of unexpected behavior? you can Just do the check in the plugin you are using. |
Contributor
Author
|
@justgo97 so, for what reason we have CHECK_ISPLAYER(), CHECK_CONNECTED(), m_bMapHasBombTarget and m_bMapHasBombZone checks in the same function? According to your logic, then we need to check almost everything in plugins.
|
wopox1337
changed the title
rg_give_defusekit(): Add player team check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add player team check to avoid unexpected behavior
fix #233