Skip to content

feat: left/right collapsible sidebars#93

Merged
sergioramos merged 11 commits into
mainfrom
68-collapsible-left-and-right-sidebars
Jun 7, 2023
Merged

feat: left/right collapsible sidebars#93
sergioramos merged 11 commits into
mainfrom
68-collapsible-left-and-right-sidebars

Conversation

@cguedes

@cguedes cguedes commented Jun 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes #68

This PR adds collapsible panels on the left and right.

  • The left collapses like VS Code.

    • You click in the "dark sidebar" to toggle what you see (Explorer, References).
    • If you click the active pane collapses (toggle). If collapsed, a click on any sidebar icon will open back the sidebar. The sidebar can also be collapsed by resizing (close and open) the vertical handle.

  • The right panel collapses to a widget in the bottom right

    • Closed by clicking a x icon
    • Opens by clicking a ^ chevron icon in the widget
    • Widget has a fixed width

refstudio-left-right

image

@cguedes cguedes linked an issue Jun 5, 2023 that may be closed by this pull request
Collapsible left and right sidebars #68
Closed
@cguedes cguedes requested a review from sehyod June 5, 2023 13:37
@cguedes cguedes marked this pull request as ready for review June 5, 2023 13:37
sehyod
sehyod previously approved these changes Jun 5, 2023
View reviewed changes
Comment thread src/App.tsx Outdated
Comment thread src/components/PanelWrapper.tsx Outdated
sehyod
sehyod previously approved these changes Jun 5, 2023
View reviewed changes
@hammer

hammer commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Fun! There seems to be some kind of state issue though, as when I first tried this out I collapsed the left sidebar first, then collapsed the right sidebar. When I collapsed the right sidebar, the left sidebar jumped back out at the same time! If I then collapse the left sidebar, they are both collapsed.

I also got it into a state where I can collapse both with one click:

Screen.Recording.2023-06-05.at.9.21.02.PM.mov

@hammer

hammer commented Jun 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@cguedes were the issues I found fixed?

@cguedes

cguedes commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator Author

@hammer not yet. Will work on this now.

@sergioramos sergioramos changed the title 68-collapsible-left-and-right-sidebars feat: left/right collapsible sidebars Jun 7, 2023
@sergioramos sergioramos merged commit cf7cb27 into main Jun 7, 2023
@sergioramos sergioramos deleted the 68-collapsible-left-and-right-sidebars branch June 7, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sehyod sehyod sehyod left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collapsible left and right sidebars

4 participants

@cguedes @hammer @sehyod @sergioramos